fix(routing/http/server): adjust bucket sizes for http metrics#724
Merged
fix(routing/http/server): adjust bucket sizes for http metrics#724
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 60.35% 60.33% -0.02%
==========================================
Files 243 243
Lines 31057 31057
==========================================
- Hits 18744 18738 -6
- Misses 10643 10650 +7
+ Partials 1670 1669 -1
... and 7 files with indirect coverage changes 🚨 Try these New Features:
|
hsanjuan
approved these changes
Nov 19, 2024
lidel
approved these changes
Nov 19, 2024
lidel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses feedback from ipfs/someguy#87 (review) and introduced more realistic size buckets for the response size histogram.
Reference numbers