refactor: default to prometheus.DefaultRegisterer#722
Merged
Conversation
lidel
changed the title
lidel
force-pushed
the
use-default-metrics-registry
branch
3 times, most recently
from
119816e to
fb39749
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #722 +/- ##
==========================================
+ Coverage 60.31% 60.33% +0.02%
==========================================
Files 244 244
Lines 31034 31036 +2
==========================================
+ Hits 18717 18725 +8
+ Misses 10644 10639 -5
+ Partials 1673 1672 -1
|
3 tasks
lidel
changed the title
lidel
force-pushed
the
use-default-metrics-registry
branch
from
fb39749 to
edd18aa
Compare
Member
Author
|
I think the approach of special-casing tests is too tedious, especially if people elaready use boxo modules in their tests, we will be breaking them forcing people to add similar wrappers. We have a different approach in boxo/gateway/metrics where we catch "duplicate registration" error and log error instead. This way all tests can run in parallel without extra wrapper. So next steps here:
|
lidel
force-pushed
the
use-default-metrics-registry
branch
from
edd18aa to
678be0d
Compare
Member
Author
|
Pushed refactored version. Boxo will no longer panic when This way
|
lidel
force-pushed
the
use-default-metrics-registry
branch
from
678be0d to
e345d49
Compare
replace NewRegistry() call with global `prometheus.DefaultRegisterer` so by default boxo users who did not specify custom registry are not missing any metrics
lidel
force-pushed
the
use-default-metrics-registry
branch
from
e345d49 to
6b292d9
Compare
hsanjuan
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes on top of #718
It replaces
prometheus.NewRegistry()calls withprometheus.DefaultRegistererto ensure that by default boxo users who do not specify an explicit registry are not missing some of the metrics.This convention is what go-libp2p does already, and I feel boxo should follow, to remove confusion why some metrics are present, and some are missing.
TODO
prometheus.DefaultRegistereris used and tests are run in parallelregistry.MustRegister