Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #55 +/- ##
=======================================
Coverage 63.75% 63.75%
=======================================
Files 32 32
Lines 1694 1694
=======================================
Hits 1080 1080
Misses 477 477
Partials 137 137 |
Closed
BigLep
approved these changes
Jan 25, 2023
Contributor
BigLep
left a comment
BigLep
left a comment
There was a problem hiding this comment.
I don't know if there's more we should be doing here, but I see no harm here :). Thanks for adding!
Contributor
|
I was about to add that exact thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to try this for now without enforcing minimum coverage requirements and see how it goes.