Skip to content

refactor: replace boxo/ipld/car by ipld/go-car#400

Merged
hacdias merged 3 commits intomainfrom
remove-car
Jun 29, 2023
Merged

refactor: replace boxo/ipld/car by ipld/go-car#400
hacdias merged 3 commits intomainfrom
remove-car

Conversation

@hacdias
Copy link
Member

@hacdias hacdias commented Jun 29, 2023

Closes #218.

Kubo Sharness is expected to fail here since Kubo can't build without being updated. See PR above.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #400 (ebf11cf) into main (8424cf4) will decrease coverage by 2.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   51.45%   48.64%   -2.82%     
==========================================
  Files         280      245      -35     
  Lines       33456    29767    -3689     
==========================================
- Hits        17216    14480    -2736     
+ Misses      14501    13860     -641     
+ Partials     1739     1427     -312     
Impacted Files Coverage Δ
examples/gateway/car/main.go 11.53% <ø> (ø)
gateway/blocks_backend.go 44.94% <ø> (ø)

... and 17 files with indirect coverage changes

@hacdias hacdias requested a review from Jorropo June 29, 2023 08:37
@hacdias hacdias marked this pull request as ready for review June 29, 2023 11:14
@hacdias hacdias requested review from a team and lidel as code owners June 29, 2023 11:14
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"github.com/ipld/go-car": "github.com/ipfs/boxo/ipld/car",

-		"github.com/ipld/go-car":                         "github.com/ipfs/boxo/ipld/car",
+		"github.com/boxo/ipld/car":                       "github.com/ipld/go-car",

@hacdias hacdias requested a review from Jorropo June 29, 2023 13:51
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI expecting to be green after PR cycle.

@hacdias hacdias merged commit fdad9f9 into main Jun 29, 2023
@hacdias hacdias deleted the remove-car branch June 29, 2023 14:03
@BigLep BigLep mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Handle relationship between boxo and go-car and go-merkledag

2 participants