Conversation
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
==========================================
+ Coverage 49.49% 49.53% +0.04%
==========================================
Files 248 248
Lines 29838 29838
==========================================
+ Hits 14769 14781 +12
+ Misses 13640 13632 -8
+ Partials 1429 1425 -4 |
galargh
commented
Jun 28, 2023
hacdias
approved these changes
Jun 29, 2023
Member
|
@galargh question: will we need to add |
Contributor
Author
Good call! How about we trigger only on PRs that modify Go files (including go.mod/go.sum)? I think that should cover the cases where CHANGELOG update might be required. |
Member
Contributor
Author
Member
|
Okay, I think it sounds good. I'm happy to get this merged. We can always make any improvements if we find something. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #267
This PR adds a CI workflow which checks whether the PR contains CHANGELOG.md modifications.
The check can be skipped by either adding
[skip changelog]to the PR title or labelling the PR withskip/changelog. These instructions are included in the PR template and in the workflow failure message.The checks succeeds if CHANGELOG.md was modified and fails otherwise.
Tested in galargh/.github#40