rename unixfs protobuf package to unixfs.v1#318
Merged
aschmahmann merged 1 commit intomainfrom Jun 7, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 49.02% 49.04% +0.02%
==========================================
Files 280 280
Lines 33802 33802
==========================================
+ Hits 16572 16579 +7
+ Misses 15467 15462 -5
+ Partials 1763 1761 -2
|
14 tasks
This was referenced May 30, 2023
Closed
… collisions with go-unixfs. Also regenerate protobufs with latest gogo
aschmahmann
force-pushed
the
fix/unixfs-pb-collision
branch
from
31895f1 to
116b830
Compare
Jorropo
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents collisions with the go-unixfs protobuf names. Also regenerate the protobufs with the latest gogo.
Mostly matches #212.
Tested in ipfs/kubo#9899 (there are test failures, but unrelated to UnixFS or IPLD in general)
cc @dirkmc