ci(gateway): enable subdomain conformance#246
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 47.87% 48.15% +0.28%
==========================================
Files 269 269
Lines 32976 32957 -19
==========================================
+ Hits 15787 15871 +84
+ Misses 15514 15422 -92
+ Partials 1675 1664 -11
|
hacdias
force-pushed
the
ci/gateway-conformance-subdomain
branch
2 times, most recently
from
0bc8590 to
d95ed57
Compare
hacdias
commented
Mar 31, 2023
galargh
reviewed
Mar 31, 2023
hacdias
force-pushed
the
ci/gateway-conformance-subdomain
branch
from
d95ed57 to
0862a5f
Compare
hacdias
force-pushed
the
ci/gateway-conformance-subdomain
branch
from
0862a5f to
725a8f4
Compare
galargh
approved these changes
Mar 31, 2023
lidel
approved these changes
Mar 31, 2023
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
Thank you! 🚢
(while looking at this, found unrelated nit: #176 (review))
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the subdomain conformance gateway tests (added in #237). Since we are using the CAR example to run the Gateway tests, we need to make it more conformant, of course, similarly to what happened in ipfs-inactive/bifrost-gateway#66.
example.net(domain used in examples)CONNECTsupport to the gateway examples.commonsubpackage since it was the same for both examples.