Add support for .Net Core scripting #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
using a set of valid min versions we now look for the highest version that matches a particular version bound we set. Default to 3.0.100 for the SDK and 3.0.0 for the runtime
Contributor
|
With the latest changes we should be ready to go. To summarize:
This should be reasonably future-proof while ensuring a minimum standard of support. I also threaded through the netfx/netcore flag into the background processing/parsing of files, which required a data contract change and looks invasive, but otherwise was pretty mechanical. This works great for me on OSX, should work similarly on any windows/unix machines so long as the documentation about default install locations is correct. Next steps would be to review/merge, then in Ionide use the user's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work by me @baronfel to get back good scripting experience in FSAC.
We need to support following case:
fsi.exeand usenet462referencesfsi.exe(net462references) anddotnet fsi(netcoreapp3.0references). User can choose which one they want to target withUseSdkScriptssettings.Currently some logic around resolving correct set of references is in this PR rather than FCS - dotnet/fsharp#7701
Discussion about FSI support in FSAC - #465