docs(readme): change incorrect module URLs#1454
Merged
christian-bromann merged 1 commit intoionic-team:mainfrom May 14, 2025
KenTandrian:fix/docs-readme-links
Merged
docs(readme): change incorrect module URLs#1454christian-bromann merged 1 commit intoionic-team:mainfrom KenTandrian:fix/docs-readme-links
christian-bromann merged 1 commit intoionic-team:mainfrom
KenTandrian:fix/docs-readme-links
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ionicons team,
While following the installation guide in the Readme, I noticed that the HTML code snippets for including the Ionicons loader via ESM CDN were not working as expected.
Based on ESM CDN documentation, the standard URL syntax is typically:
Hence, I have updated the URLs to move
/loaderpathname to the end, following the standard format.https://esm.sh/ionicons@latest/loader
This correction appears to resolve the issue.