breaking: modernize project#1447
Conversation
christian-bromann
force-pushed
the
cb/update
branch
from
1b98eb0 to
6c81a4e
Compare
christian-bromann
requested review from
a team,
brandyscarney,
gnbm and
thetaPC
and removed request for
a team
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
The cheat sheet has broken links when clicking on an icon, might be worth fixing.
It might beneficial to add more comments of what's going on. We don't often work in this repo so comments would be a nice refresher.
Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
|
@brandyscarney @thetaPC thanks for the review, I've addressed the feedback. |
Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
There was a problem hiding this comment.
Do you know why fill="currentColor" was added to these 3 svgs? I don't see it in any others except for src/svg/chevron-collapse-sharp.svg
There was a problem hiding this comment.
It was requested in some of the issues I triaged. Do you have any concerns with the change?
There was a problem hiding this comment.
I tested setting color on each of them without fill="currentColor" and they seem to still work fwiw
There was a problem hiding this comment.
Sorry I didn't see your reply when I added my 2nd comment. We ran into some issues in the past with stroke:#000 being added to the svgs and it caused issues with being able to override the color, so I am always overly cautious here, but this change shouldn't do that.
I am curious how to reproduce the problem in #1420 though because I tried setting the color directly and still see it inheriting on the dots:
<ion-icon style="color: red" name="bowling-ball-outline"></ion-icon>
<ion-icon style="color: red" name="chevron-collapse-sharp"></ion-icon>
<ion-icon style="color: red" name="information-circle-outline"></ion-icon>
<ion-icon style="color: red" name="warning-outline"></ion-icon>
<ion-icon color="primary" name="bowling-ball-outline"></ion-icon>
<ion-icon color="secondary" name="chevron-collapse-sharp"></ion-icon>
<ion-icon color="tertiary" name="information-circle-outline"></ion-icon>
<ion-icon color="success" name="warning-outline"></ion-icon>
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Everything looks good in my testing! Non-blocking comment on the svgs adding fill="currentColor".
It might be helpful if we add a note in the Contributing guide on how to setup and run the Playwright tests (including installing Playwright), but I don't think it's required for this PR.
Thanks for doing this! Great work. 🚀
One thing to note — we should discuss whether or not this should be merged into main or if we should put it into a feature branch.
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
LGTM, I only have a non-blocking comment.
Can you elaborate on this? |
|
As discussed offline, this will be merged into |
3 participants
This patch will modernize the Ionicons project, it includes the following changes:
update docsdeferred to Improve documentation on how to use Ionicons #1448