Skip to content

fix(vue): swipe back gesture is properly disabled when swipeBackEnabled config is false #22568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liamdebeasi merged 1 commit into from
Nov 30, 2020
Merged

fix(vue): swipe back gesture is properly disabled when swipeBackEnabled config is false #22568

liamdebeasi merged 1 commit into from
Nov 30, 2020

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 25, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22567

What is the new behavior?

  • Add config check for swipeBackEnabled

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: vue @ionic/vue package label Nov 25, 2020
@liamdebeasi liamdebeasi merged commit 9d04c12 into master Nov 30, 2020
@liamdebeasi liamdebeasi mentioned this pull request Nov 30, 2020
Closed
@liamdebeasi liamdebeasi deleted the vue-swipe-back-config branch November 30, 2020 15:59
@mpaland
Copy link

mpaland commented Nov 2, 2021

@liamdebeasi is this really tested and fixed in the latest ionic/vue version?
I'm testing a pretty basic PWA on an IOS iPad with:

const app = createApp(App)
  .use(IonicVue, {
    rippleEffect: false,
    swipeBackEnabled: false,
    mode: 'ios'
  })
  .use(router);

and I still can swipe forward and backward between pages, considering this behavior as a bug.
Any help appreciated.

@liamdebeasi
Copy link
Contributor Author

liamdebeasi commented Nov 2, 2021

The swipe back built into Ionic is different than the swipe back built into Safari. See: #22299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: vue @ionic/vue package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: ionic vue swipeBackEnabled config does not work

3 participants

@liamdebeasi @mpaland