add mod to automatically show slide page numbers#28
Merged
ionelmc merged 4 commits intoionelmc:masterfrom Nov 11, 2021
Merged
Conversation
It's possible that the goal here was to mention `mods/wide16x9/` instead, but the text still doesn't seem to describe the expected behavior. But I don't think it overrides `themes/default/` -- I think it overrides any theme, not just the default. So dropping it seems simplest. At any rate, if we want to guide the user about risks of using `--mod=wide16x9` (or any mod), we should warn them in the documentation for `--mod`, not in this side note about making widescreen slides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this incorporates the cleanups proposed in #27.
Closes: #26