feat(firestore): data bundles API by kmsbernard · Pull Request #6199 · invertase/react-native-firebase

kmsbernard · 2022-04-14T15:09:45Z

Description

Add Firestore bundles API: loadBundle() and namedQuery()

Related issues

Release Summary

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
- Yes
My change supports the following platforms;
- Android
- iOS
My change includes tests;
- e2e tests added or updated in packages/\*\*/e2e
- jest tests added or updated in packages/\*\*/__tests__
I have updated TypeScript types that are affected by my change.
This is a breaking change;
- Yes
- No

Test Plan

Think react-native-firebase is great? Please consider supporting the project with any of the below:

👉 Star this repo on GitHub ⭐️
👉 Follow React Native Firebase and Invertase on Twitter

vercel · 2022-04-14T15:09:50Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/9AyXnLYQ6CKHZ4DSLMuZpQvJVXqF
✅ Preview: https://react-native-firebase-git-fork-bernard-kms-fir-1af0bd-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/CRJYE2X3tGbgsKpHjaxZmNnX6CTp
✅ Preview: Ignored

[Deployment for 00d0009 canceled]

codecov · 2022-04-14T15:11:23Z

Codecov Report

Merging #6199 (9bfb0b2) into main (ef7895c) will decrease coverage by 18.64%.
The diff coverage is 84.56%.

❗ Current head 9bfb0b2 differs from pull request most recent head bdb2a80. Consider uploading reports for the commit bdb2a80 to get more accurate results

@@              Coverage Diff              @@
##               main    #6199       +/-   ##
=============================================
- Coverage     72.11%   53.48%   -18.63%     
- Complexity        0      649      +649     
=============================================
  Files           109      208       +99     
  Lines          4618    10302     +5684     
  Branches       1040     1633      +593     
=============================================
+ Hits           3330     5509     +2179     
- Misses         1210     4539     +3329     
- Partials         78      254      +176

mikehardy · 2022-04-19T21:55:48Z

I think the android test failure in e2e ci was a flaky test, I restarted it
the documentation one is really easy to fix: just add CDN to spellcheck.dict in root and that one will go green

…test-reuse

mikehardy

This is fantastic! I pulled it locally and stabilized it across repeated runs via test:<platform>:test-reuse where you need to call firestore().clearPersistence() on startup so that there are no cached non-bundle docs before the run, but otherwise it just worked.

This was one of the flagship features added to firebase in 2021 and it really nagged me that we didn't have it yet, I truly appreciate your posting this! Hopefully lots of people put it to use and enjoy some cost savings

kmsbernard · 2022-04-27T08:22:11Z

Wow, thanks for a quick merge & release!

mikehardy · 2022-04-27T11:24:24Z

Ha! I actually felt like 7 days after you were done before merge was patient on your part! There is no real bureaucracy here so things can move really quickly, I was pretty behind, from work on other repos 😅

kmsbernard · 2022-04-27T12:43:20Z

I think my last week went by like crazy that I felt it short. 😂 And don't have to be sorry about the "behind", I always appreciate your tremendous work in maintaining the library!

kmsbernard added 7 commits April 14, 2022 20:25

add test cases

302d491

add loadBundle interface

3258320

install isomorphic-fetch

71480b4

enhance tests

6021688

implement loadBundle in android side

bfb19dc

update comments

5e96851

implement loadBundle in iOS

82bf24c

vercel Bot deployed to Preview – react-native-firebase April 14, 2022 15:09 View deployment

vercel Bot temporarily deployed to Preview – react-native-firebase-next April 14, 2022 15:09 Inactive

kmsbernard changed the title ~~feat(firestone): data bundles API~~ feat(firestore): data bundles API Apr 14, 2022

mikehardy added the Workflow: Needs Review Pending feedback or review from a maintainer. label Apr 14, 2022

kmsbernard added 5 commits April 15, 2022 10:22

use specific charsets to get byte array

3ab16d0

implement basic nameQuery

b4e9320

enhance implemantation

a6b115e

extract getSource method

a64ef17

add test case for query modification

58489dd

vercel Bot deployed to Preview – react-native-firebase April 15, 2022 06:51 View deployment

vercel Bot temporarily deployed to Preview – react-native-firebase-next April 15, 2022 06:52 Inactive

kmsbernard added 3 commits April 15, 2022 16:06

add type def

413d7ee

implement basic nameQuery in iOS

3ac68ca

enhance test when omitting cache

9e39128

vercel Bot deployed to Preview – react-native-firebase April 15, 2022 08:43 View deployment

vercel Bot temporarily deployed to Preview – react-native-firebase-next April 15, 2022 08:43 Inactive

kmsbernard added 4 commits April 15, 2022 18:19

implement basic namedQueryOnSnapshot

00cadf0

abstract internal methods

80637e6

add javascript test cases

f93994a

add documentation

0ad081d

vercel Bot deployed to Preview – react-native-firebase April 15, 2022 10:59 View deployment

kmsbernard added 2 commits April 17, 2022 15:46

apply linter

ba8d550

tidy task progress serialization

f9483d9

vercel Bot temporarily deployed to Preview – react-native-firebase-next April 17, 2022 08:48 Inactive

vercel Bot deployed to Preview – react-native-firebase April 17, 2022 08:48 View deployment

mikehardy reviewed Apr 19, 2022

View reviewed changes

Comment thread packages/firestore/e2e/Bundle/namedQuery.e2e.js Outdated

mikehardy reviewed Apr 19, 2022

View reviewed changes

Comment thread ...ges/auth/android/src/main/java/io/invertase/firebase/auth/ReactNativeFirebaseAuthModule.java

kmsbernard added 3 commits April 20, 2022 10:59

add comments on loadBundle test

cf6efe6

add CDN to spellcheck.dict

2dfc6cf

alter bundle requests with static resource

be8dd67

vercel Bot deployed to Preview – react-native-firebase April 20, 2022 03:13 View deployment

kmsbernard marked this pull request as ready for review April 20, 2022 04:56

lint: result of yarn lint:android for java formatting

c3fefab

mikehardy reviewed Apr 26, 2022

View reviewed changes

Comment thread .../android/src/main/java/io/invertase/firebase/firestore/UniversalFirebaseFirestoreModule.java Outdated

vercel Bot deployed to Preview – react-native-firebase April 26, 2022 21:55 View deployment

mikehardy reviewed Apr 26, 2022

View reviewed changes

Comment thread docs/firestore/usage/index.md Outdated

Update docs/firestore/usage/index.md

ae42e5a

vercel Bot deployed to Preview – react-native-firebase April 26, 2022 22:06 View deployment

mikehardy added 2 commits April 26, 2022 17:32

chore: httpGet no longer needed, bundle available statically

fa2e865

test(firestore, bundles): centralize before logic / stabilize across …

bdb2a80

…test-reuse

mikehardy approved these changes Apr 26, 2022

View reviewed changes

vercel Bot deployed to Preview – react-native-firebase April 26, 2022 23:59 View deployment

mikehardy added Workflow: Pending Merge Waiting on CI or similar and removed Workflow: Needs Review Pending feedback or review from a maintainer. labels Apr 26, 2022

mikehardy merged commit 96591e0 into invertase:main Apr 27, 2022

mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Apr 27, 2022

mikehardy mentioned this pull request Apr 28, 2022

loadBundle() Error: [firestore/unknown] Unknown error or an error from a different error domain. #6224

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(firestore): data bundles API#6199

feat(firestore): data bundles API#6199
mikehardy merged 40 commits into
invertase:mainfrom
kmsbernard:firestore-bundle

kmsbernard commented Apr 14, 2022 •

edited

Loading

Uh oh!

vercel Bot commented Apr 14, 2022 •

edited

Loading

Uh oh!

codecov Bot commented Apr 14, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

mikehardy commented Apr 19, 2022

Uh oh!

Uh oh!

Uh oh!

mikehardy left a comment

Uh oh!

kmsbernard commented Apr 27, 2022

Uh oh!

mikehardy commented Apr 27, 2022

Uh oh!

kmsbernard commented Apr 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kmsbernard commented Apr 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Release Summary

Checklist

Test Plan

Uh oh!

vercel Bot commented Apr 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

react-native-firebase – ./

react-native-firebase-next – ./website_modular

Uh oh!

codecov Bot commented Apr 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

mikehardy commented Apr 19, 2022

Uh oh!

Uh oh!

Uh oh!

mikehardy left a comment

Choose a reason for hiding this comment

Uh oh!

kmsbernard commented Apr 27, 2022

Uh oh!

mikehardy commented Apr 27, 2022

Uh oh!

kmsbernard commented Apr 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kmsbernard commented Apr 14, 2022 •

edited

Loading

vercel Bot commented Apr 14, 2022 •

edited

Loading

codecov Bot commented Apr 14, 2022 •

edited

Loading