Skip to content

fix(firestore): fix firestore settings type definition#4965

Merged
mikehardy merged 1 commit into
invertase:masterfrom
kmsbernard:typescript-firestore-settings
Feb 28, 2021
Merged

fix(firestore): fix firestore settings type definition#4965
mikehardy merged 1 commit into
invertase:masterfrom
kmsbernard:typescript-firestore-settings

Conversation

@kmsbernard

@kmsbernard kmsbernard commented Feb 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fix firestore.Settings type definition to make each field could be optional. As per implementation of firebase.firestore().settings(), it was intended to be optional.

And also follows firebase-js-sdk's type definitions: https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore-types/index.d.ts

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Think react-native-firebase is great? Please consider supporting the project with any of the below:

🔥

@CLAassistant

CLAassistant commented Feb 28, 2021 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@vercel

vercel Bot commented Feb 28, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/4Gu19xzt9QjM4yijhb1M25pZxjjc
✅ Preview: https://react-native-f-git-fork-bernard-kms-typescript-firestore-638913.vercel.app

@codecov

codecov Bot commented Feb 28, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4965 (874c61b) into master (bc893ab) will decrease coverage by 52.37%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4965       +/-   ##
===========================================
- Coverage   89.21%   36.84%   -52.36%     
===========================================
  Files         105       48       -57     
  Lines        3482     1455     -2027     
  Branches        0      348      +348     
===========================================
- Hits         3106      536     -2570     
- Misses        376      697      +321     
- Partials        0      222      +222

mikehardy
mikehardy approved these changes Feb 28, 2021
View reviewed changes

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Thanks for the link to the firebase-js-sdk for quick verification
You are correct and this looks good to me

@mikehardy
mikehardy merged commit f501fff into invertase:master Feb 28, 2021
@dependabot dependabot Bot mentioned this pull request Mar 17, 2021
Closed
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
@kmsbernard
fix(firestore, types): make all Settings properties optional (inverta…
328fcb8 
…se#4965)

This matches the optional typing of all Settings members in firebase-js-sdk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kmsbernard @CLAassistant @mikehardy