Initial commit. Separating out list generation into a helper method#849
Merged
isc-jlechtne merged 8 commits intomainfrom Jul 9, 2025
Merged
Initial commit. Separating out list generation into a helper method#849isc-jlechtne merged 8 commits intomainfrom
isc-jlechtne merged 8 commits intomainfrom
Conversation
added 7 commits
July 7, 2025 16:35
…and order matters
isc-jlechtne
requested review from
isc-eneil,
isc-jili,
isc-kiyer and
isc-tleavitt
isc-eneil
requested changes
Jul 8, 2025
Collaborator
isc-eneil
left a comment
isc-eneil
left a comment
There was a problem hiding this comment.
I suggested one small method description change, but otherwise looks good to me!
src/cls/IPM/Storage/Module.cls
Outdated
| Property Deployed As %Boolean(XMLPROJECTION = "Element"); | ||
|
|
||
| /// This method iterates over resources of a module and returns a list of objects in the correct order that resources should be processed | ||
| /// Process resources based on their package depth (higher level first so more granular resource will override) |
Collaborator
There was a problem hiding this comment.
@isc-jlechtne Isn't the package depth processing just for Document resources, then the rest of resources are processed in the order in which they are declared in the module's module.xml?
Contributor
Author
There was a problem hiding this comment.
That is correct. Will update the method description to include that info as well
isc-jili
previously approved these changes
Jul 8, 2025
isc-jili
approved these changes
Jul 8, 2025
isc-eneil
approved these changes
Jul 8, 2025
isc-kiyer
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #848
Idea is to create a helper method which compiles all resources into one list in their proper processing order. Lifecycle methods can then use this
orderedResourceList.GetNext(.tKey)instead of..Module.Resources.GetNext(.tKey)