Cloning an existing repo with Configure overwrites settings from file#860
Cloning an existing repo with Configure overwrites settings from file#860isc-pbarton merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
=======================================
Coverage 49.77% 49.77%
=======================================
Files 24 24
Lines 3281 3281
=======================================
Hits 1633 1633
Misses 1648 1648 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Includes changes from #859 as well because I did not feel like resolving a merge conflict later. |
isc-dchui
left a comment
isc-dchui
left a comment
There was a problem hiding this comment.
Just a quick question.
There was a problem hiding this comment.
So this PR also contains the changes for #859. Is that intentionally to avoid a merge conflict later? If so, will the git history correctly reflect that these changes are not actually from this PR?
There was a problem hiding this comment.
Oh wait sorry didn't see your earlier comment
There was a problem hiding this comment.
@isc-dchui Yep, that was intentional to avoid merge conflict on the changelog. The history should be all good now - I merged #859 and changed the base on this repo to force GitHub to refresh its data associating commits to PRs.
3 participants
resolves #819
If the cloned repo has a settings file, its values will overwrite those chosen earlier in the Configure prompts. I agree with the requestor that this is always desired behavior.