Delete 68 legacy image files no longer referenced anywhere - #13329
Merged
lokesh merged 8 commits intoAug 25, 2026
Conversation
21 of these were replaced by sprite icons in internetarchive#12955; the other 29 have had no references in the codebase for years and turned up while auditing. Verified none of the 50 is referenced from any template, JS, CSS or Python on the icon-system branch. Split out of internetarchive#12955 so that PR carries no binary content: GitHub's .diff omits binary data, so a patch deploy of a PR containing binary deletions aborts unless it passes --exclude=static/images/*. This one never needs to reach testing, so the flag stops mattering. Merge after internetarchive#12955. Claude-Session: https://claude.ai/code/session_01Lv9GuFfV3JRG7hmKGmN1t4
lokesh
force-pushed
the
icons/chore/delete-legacy-images
branch
from
August 21, 2026 22:57
c1cde8d to
2f8af29
Compare
The delete/remove control on list pages was an anchor with a sprite-image trashcan; it now uses ol-button with the trash icon, which lets the last of the legacy image files go. On a list's own page the button moves into the CTA column under the lending button and dropper, so the dropper's ad-hoc margin and its 50px reservation for the absolutely positioned control give way to a single flex gap owning the rhythm. Claude-Session: https://claude.ai/code/session_01NmxEn3FtZunApjLZAW78wo
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 1 issue across 1 rule.
Reviewed by AccessLint, which checks every pull request for accessibility issues.
| <div class="clearfix"></div> | ||
|
|
||
| <ul id="listResults" class="list-books clearfix $cond(layout == 'grid', 'list-books--grid')"> | ||
| <ul id="listResults" class="list-books list-seeds clearfix $cond(layout == 'grid', 'list-books--grid')"> |
There was a problem hiding this comment.
WCAG 1.3.1: <ul> contains direct text content. Wrap in <li> or <style>.
<ul> and <ol> must only contain <li>, <script>, <template>, or <style> as direct children.
Details
Screen readers announce list structure ('list with 5 items') based on proper markup. Placing non-<li> elements directly inside <ul> or <ol> breaks this structure. Wrap content in <li> elements, or if you need wrapper divs for styling, apply styles to <li> elements directly and remove the wrapper (e.g., change <ul>``<div>item</div>``</ul> to <ul>``<li>item</li>``</ul>).
The 17 lucide additions had ridden along in the ol-button commit with nothing consuming them; they now land via internetarchive#13424 instead. Claude-Session: https://claude.ai/code/session_01RtTEd3rAHJYz3zKi3zUWwD
The matcher test used the now-deleted barcode_scanner.svg as its sample path. Claude-Session: https://claude.ai/code/session_01RtTEd3rAHJYz3zKi3zUWwD
lokesh
changed the title
The grid variant applied to every .list-books--grid (search results, author pages, reading log), not just list seeds. Claude-Session: https://claude.ai/code/session_01RtTEd3rAHJYz3zKi3zUWwD
lokesh
force-pushed
the
icons/chore/delete-legacy-images
branch
from
August 25, 2026 05:18
e91d622 to
bfcec93
Compare
Restores the list templates, JS, and CSS to master and keeps back_list-trash.png, whose last reference lives until internetarchive#13425 lands. This PR is back to being a pure deletion of unreferenced files. Claude-Session: https://claude.ai/code/session_01RtTEd3rAHJYz3zKi3zUWwD
lokesh
changed the title
lokesh
marked this pull request as ready for review
August 25, 2026 05:34
lokesh
added
the
Needs: Review
The audit grep missed the %20-encoded url() in buttonCta.css:39, so deleting the file would blank the open-access audiobook button icon. It goes once that button is on the sprite (icons/chore/phase2-icon-set). Claude-Session: https://claude.ai/code/session_01RtTEd3rAHJYz3zKi3zUWwD
lokesh
changed the title
github-project-automation
Bot
moved this to Waiting Review/Merge from Staff
in Ray's Project
RayBB
approved these changes
Aug 25, 2026
RayBB
left a comment
RayBB
left a comment
Collaborator
There was a problem hiding this comment.
I did a pretty thorough check and cannot find any usages anywhere so I think we're good to go. Also put on testing for good measure.
github-project-automation
Bot
moved this from Waiting Review/Merge from Staff
to Done
in Ray's Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12955 (unified icon system).
Deletes 68 image files that are no longer referenced by any template, JS, CSS or Python:
static/images/found 18 more (old carousel arrows,waiting.gif,wmd-buttons.png, colorbox sprites, and similar).Verified against current master that none of the 68 filenames appears in any template, JS, CSS or Python file. The service-worker matcher test fixture that pointed at one of the deleted files now uses a surviving image; that one-line test change is the only non-deletion in the diff.