Use docker compose extra_hosts to work around ol-home0 issues#13198
Merged
Conversation
ol-home0 services are unable to make requests to other containers when accessing through the FQDN. This work around allows us to change the openlibrary.yml to use infobase_nginx:7000, which will work for ol-home0 nodes since they are on the same docker network, and we use extra_hosts for non-ol-home0 nodes that need to access infobase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5143
ol-home0 services are unable to make requests to other containers when accessing through the FQDN. This work around allows us to change the openlibrary.yml to use infobase_nginx:7000, which will work for ol-home0 nodes since they are on the same docker network, and we use extra_hosts for non-ol-home0 nodes that need to access infobase.
See https://github.com/internetarchive/olsystem/pull/400
Technical
Testing
Screenshot
Stakeholders