fix(a11y): add aria-label to generic-dropper arrow button (link-name WCAG 2.4.4) - #13029
Merged
Conversation
…ame WCAG 2.4.4) The arrow button that opens the reading-list dropdown had no discernible text, causing axe link-name violations (~20 nodes on /search, ~21 on /authors). lib/dropper.html now accepts an optional dropdown_label; the my_books dropper passes a book-title-contextual label so screen readers announce "More reading options for <title>" per each card. Fixes #13009 (WCAG 2.4.4 link-name)
mekarpeles
added
the
Theme: Accessibility
Collaborator
|
Resolved the |
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<a class="generic-dropper__dropclick">(the arrow to open the reading-list dropdown) had only a<div class="arrow">child — no accessible text, violating WCAG 2.4.4 (Link Purpose).dropdown_labelparameter tolib/dropper.htmlwith a default of_('More options').my_books/dropper.htmlpasses a book-title-contextual label:_('More reading options for %(title)s', title=title)(or_('More reading options')when no title is available).link-nameviolations on/searchand ~21 on/authors/*.Test plan
/search?q=the+great+gatsby— inspect arrow button; confirmaria-label="More reading options for <title>"on each card.12885/playwright-e2e-testsworktree (see PR test(e2e): add Playwright smoke test suite for core OL pages #12998).Part of WCAG 2.1 AA a11y remediation — tracked in #13009