fix(a11y): add title attributes to iframes (WCAG 2.4.1 H64) - #13012
Merged
Conversation
Iframes must have a title attribute so screen readers can identify their purpose before deciding whether to enter them. - ia_thirdparty_logins.html: title="Sign in with a third-party account" (IA social login widget rendered on login and signup pages) - BookPreview.html: title="Book preview" (floating preview dialog, JS-populated on demand) Excluded: reCAPTCHA iframe on signup page is third-party JS (Google); its title is not under OL template control. Playwright regression test staged in #12998 (tests/e2e/a11y/frame-title.spec.ts). Fixes: frame-title axe rule / WCAG 2.4.1 H64 Closes: #13008
mekarpeles
added
the
Theme: Accessibility
mekarpeles
added a commit
that referenced
this pull request
Jun 23, 2026
Playwright axe-core tests covering the fix in PR #13012: - login page: ia_thirdparty_logins iframe must have title - work page: BookPreview iframe must have title - signup page: OL iframes must have title (reCAPTCHA excluded) All three tests currently fail against openlibrary.org (expected — fix pending #13012 merge); will pass once the fix deploys.
mekarpeles
added a commit
that referenced
this pull request
Jun 24, 2026
Playwright axe-core tests covering the fix in PR #13012: - login page: ia_thirdparty_logins iframe must have title - work page: BookPreview iframe must have title - signup page: OL iframes must have title (reCAPTCHA excluded) All three tests currently fail against openlibrary.org (expected — fix pending #13012 merge); will pass once the fix deploys.
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Iframes must have a
titleattribute so assistive technology users can identify their purpose before deciding to navigate into them (WCAG 2.4.1 H64,frame-titleaxe rule, impact=serious).Two iframes fixed:
templates/account/ia_thirdparty_logins.html"Sign in with a third-party account"macros/BookPreview.html"Book preview"Excluded: the reCAPTCHA iframe on the signup page is injected by Google's JS library — its title is not under OL template control.
What this changes
Test plan
Playwright regression tests (
frame-title.spec.ts) are staged on branch12885/playwright-e2e-tests(PR #12998). Once the Playwright e2e infrastructure merges, CI will assert zeroframe-titleviolations on login, signup, and work pages.To verify manually:
Related
frame-title/ WCAG 2.4.1 H64