refactor: Define Line Height LESS vars - #11619
Merged
Merged
Conversation
14 tasks
Member
|
Looks good to the team, will throw on testing and if everything looks good / the same, we'll merge. Thank you! |
mystic-06
pushed a commit
to mystic-06/openlibrary
that referenced
this pull request
Jan 11, 2026
* feat: Add line-heights.less import to index.less for improved styling management * chore: Update line-height variables for improved typography consistency * refactor: Enhance line-height definitions for better semantic usage and readability
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11555
Creates a set of primitive and semantic line-height variables.
With the semantic variables, their names communicate where they should be used. This provides a single point of control for updating line heights across the app.
A separate PR will update the codebase to utilize the new variables.
Technical
These new variables continue to use LESS, but in the future we can convert them in one fell swoop to CSS custom properties.
Screenshot
No visual change.
Stakeholders
@cdrini @mekarpeles @jimchamp