fix: Hide default carousel on subject pages with associated Tags #11394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the subjects page template to conditionally display a default QueryCarousel only when a subject doesn't have an associated Tag. Previously, the QueryCarousel was shown unconditionally regardless of whether the subject had a tag or not.
- Wraps the QueryCarousel in an
$elseblock to prevent it from showing when a tag with custom body content exists - Adds a clarifying comment explaining the conditional logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11381
Fix: Exclude default carousel from subject pages when associated with a Tag
Technical
This PR modifies the subject page template to conditionally render the default QueryCarousel based on whether the subject has an associated Tag object.
Changes:
/openlibrary/templates/subjects.htmlQueryCarouselmacro call in an$elseblockhas_tagisFalse(i.e., when'tag' not in page)bodycontent is displayedTesting
/subjects/love- carousel should display