Fix some JS issues #11250
Merged
Fix some JS issues #11250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
added
Patch Deployed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses security vulnerabilities, updates dependencies, and fixes PWA configuration issues. The changes include fixing an XSS vulnerability in the barcode scanner, updating Jest and related testing dependencies to newer versions, and correcting the webpack configuration for proper PWA initialization.
- Fixed XSS vulnerability by validating returnTo parameter in BarcodeScanner component
- Updated Jest from 29.7.0 to 30.0.5 and other testing-related dependencies
- Removed problematic webpack library configuration that was preventing PWA functionality
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| openlibrary/components/BarcodeScanner.vue | Added URL validation to prevent XSS via returnTo parameter |
| package.json | Updated Jest, stylelint, and workbox dependencies; added dependency overrides |
| webpack.config.js | Removed library configuration that was interfering with PWA setup |
| openlibrary/plugins/openlibrary/js/SearchBar.js | Added getCurUrl() method for better testability |
| tests/unit/js/SearchBar.test.js | Refactored test to use stubbed method instead of mocking window.location |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cdrini
commented
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Technical
Testing
Patch deployed for the security fix, and otherwise up on testing.
Before:
Screenshot
Stakeholders