add typehints to author imports #11094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
reviewed
Sep 29, 2025
RayBB
force-pushed
the
typehints/author-import
branch
from
0ab7267 to
c923801
Compare
cdrini
approved these changes
Oct 29, 2025
Collaborator
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Wooohooo!! This looks fantastic and a huge QOL improvement 🚀
| or new candidate dict without "key". | ||
| """ | ||
| assert isinstance(author_import_record, dict) | ||
| try: |
Collaborator
There was a problem hiding this comment.
We checked, and the one place this method is used, it ensure the input is a dict, so it's cleaner to rely on the typehint here since that appears to be actually enforced!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Technical
Testing
Screenshot
Stakeholders