(Closes #8343) Create update_stale_ocaid_references.py script #10588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
added
Priority: 1
mekarpeles
commented
Mar 17, 2025
mekarpeles
commented
Mar 17, 2025
cdrini
approved these changes
Mar 18, 2025
Co-authored-by: Drini Cami <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8343
Tested on
ol-dev1onol-mek-web-1with:Then I modified the function
get_dark_ol_editionsto useq = "openlibrary_edition:* AND identifier:a*"which limited the results to a single page of about 120 instead of several thousand (for testing)i.e. the equivalent of:
https://archive.org/services/search/v1/scrape?q=openlibrary_edition%3A*%20AND%20identifier:a*%20AND%20curatedate:[2025-03%20TO%20*]&scope=dark&service=metadata__dark&count=1000&fields=identifier,openlibrary_edition
Technical
Note, I added special s3 keys to our olsystem openlibrary.yml to get this to work because the
ia_ol_metadata_write_s3keys don't have access todark. We should discuss with @ximm how we want to handle this case with respect to running this within our infrastructure daily as a cron (similar to update_stale_work_references.py).Testing
Screenshot
Stakeholders