-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Standardize Subject Tags UX using BEM CSS #11728
Copy link
Copy link
Open
Labels
Affects: UIIssues with the web site's user interface. [managed]Issues with the web site's user interface. [managed]Lead: @lokeshIssues pertaining to front-end design system [css, js, components]Issues pertaining to front-end design system [css, js, components]Needs: Design FeedbackNeeds: DesignsPriority: 3Issues that we can consider at our leisure. [managed]Issues that we can consider at our leisure. [managed]Team: Front-endIssues belonging to the Front-end team [experimental tag]Issues belonging to the Front-end team [experimental tag]Theme: Book TagsIssues related to community book tagsIssues related to community book tagsTheme: CSSIssues related to CSS stylesheets. [managed]Issues related to CSS stylesheets. [managed]Theme: DesignIssues related to UI design, branding, etc. [managed]Issues related to UI design, branding, etc. [managed]Type: Design ProposalProposing a design and soliciting feedback + approvalProposing a design and soliciting feedback + approval
Description
Activity
Metadata
Metadata
Assignees
Labels
Affects: UIIssues with the web site's user interface. [managed]Issues with the web site's user interface. [managed]Lead: @lokeshIssues pertaining to front-end design system [css, js, components]Issues pertaining to front-end design system [css, js, components]Needs: Design FeedbackNeeds: DesignsPriority: 3Issues that we can consider at our leisure. [managed]Issues that we can consider at our leisure. [managed]Team: Front-endIssues belonging to the Front-end team [experimental tag]Issues belonging to the Front-end team [experimental tag]Theme: Book TagsIssues related to community book tagsIssues related to community book tagsTheme: CSSIssues related to CSS stylesheets. [managed]Issues related to CSS stylesheets. [managed]Theme: DesignIssues related to UI design, branding, etc. [managed]Issues related to UI design, branding, etc. [managed]Type: Design ProposalProposing a design and soliciting feedback + approvalProposing a design and soliciting feedback + approval
Description, Patron Story
Currently, subject, person, place, and time tags on Open Library are rendered as plain links which are difficult to scan, are visually inconsistent, and do not serve as clear canonical tags/labels. This makes it harder for readers to visually parse important metadata at a glance and introduces visual inconsistency with other UI components. We'd like to:
Why is this design change necessary?
Who is it for?
Constraints/Considerations
.ol-tag,.ol-tag--subject)SubjectTags.html), others inline in templatesRelevant Designs
Implementation/Reference Research
Below is a technical overview for initial scoping and onboarding (include for future contributors):
Key files affecting subject/person/place tag UI
openlibrary/macros/SubjectTags.html: Macro for most book page subject/person/place tagsopenlibrary/macros/RelatedSubjects.html: Related sidebar tagsopenlibrary/templates/subjects.html,openlibrary/templates/search/subjects.html: Main subject+search result layoutsopenlibrary/templates/type/author/view.html: Author page tagsCSS locations
static/css/components/tagging-menu.less: Tag/label core styles for tagsstatic/css/legacy.less,static/css/page-subject.less: Current link/list styling, needs harmonizationGuidance for new contributors
Feedback Questions
Stakeholders
@mekarpeles, @cdrini, @jimchamp, @RayBB, @hayoonc, @beccat123, @rebecca-shoptaw, @sbwhitt
References:
static/css/components/tagging-menu.lessopenlibrary/macros/SubjectTags.html,openlibrary/macros/RelatedSubjects.html