Merge pull request #12876 from internetarchive/12857/fix-login-session-cookie

jimchamp · web-flow · commit 8220e9d00e80 · 2026-06-08T13:18:17.000-07:00
fix(accounts): always set session cookie on login regardless of OL account lookup
diff --git a/openlibrary/plugins/upstream/account.py b/openlibrary/plugins/upstream/account.py
@@ -644,19 +644,19 @@ def login(
             )
         email = email or audit.get("ia_email") or audit.get("ol_email")
 
-        if ol_account := OpenLibraryAccount.get_by_email(email):
-            _set_login_cookies(audit, ol_account, remember=remember)
-
-            if web.cookies().get("pda"):
-                add_flash_message(
-                    "info",
-                    _(
-                        "Thank you for registering an Open Library account and "
-                        "requesting special print disability access. You should receive "
-                        "an email detailing next steps in the process."
-                    ),
-                )
-                web.setcookie("pda", "", expires=1)
+        ol_account = OpenLibraryAccount.get_by_email(email)
+        _set_login_cookies(audit, ol_account, remember=remember)
+
+        if ol_account and web.cookies().get("pda"):
+            add_flash_message(
+                "info",
+                _(
+                    "Thank you for registering an Open Library account and "
+                    "requesting special print disability access. You should receive "
+                    "an email detailing next steps in the process."
+                ),
+            )
+            web.setcookie("pda", "", expires=1)
 
         blacklist = [
             "/account/login",
