Merge pull request #11864 from cdrini/deps/node-24

cdrini · web-flow · commit 5efc000332e9 · 2026-02-12T16:32:18.000-05:00
Update to node 24 LTS
diff --git a/.github/workflows/javascript_tests.yml b/.github/workflows/javascript_tests.yml
@@ -25,7 +25,7 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           # Should match what's in our Dockerfile
-          node-version: '20' # Also update the `key` in the `with` map, below
+          node-version: '24' # Also update the `key` in the `with` map, below
       - uses: actions/cache@v5
         id: npm-cache
         with:
@@ -36,7 +36,7 @@ jobs:
           # `node_modules` directly.
           path: 'node_modules'
           # Note the version number in this string -- update it when updating Node!
-          key: ${{ runner.os }}-node20-${{ hashFiles('**/package-lock.json') }}
+          key: ${{ runner.os }}-node24-${{ hashFiles('**/package-lock.json') }}
       - if: steps.npm-cache.outputs.cache-hit != 'true'
         run: npm install --no-audit
       - run: npm run lint
diff --git a/.github/workflows/new_pr_labeler.yml b/.github/workflows/new_pr_labeler.yml
@@ -4,7 +4,7 @@ on:
     types:
       - opened
 env:
-  NODE_VERSION: '20'
+  NODE_VERSION: '24'
 jobs:
   label_pr:
     # Continue only if the PR is not a draft, and was opened in the same repository that is running this action:
diff --git a/.github/workflows/weekly_status_report.yml b/.github/workflows/weekly_status_report.yml
@@ -7,7 +7,7 @@ permissions:
   contents: read
   issues: read
 env:
-  NODE_VERSION: '20'
+  NODE_VERSION: '24'
   TEAM_ABC_CONFIG: '.github/workflows/config/weekly_status_report_team_abc.json'
   LEADS_G_CONFIG: '.github/workflows/config/weekly_status_report_openlibrary_leads_g.json'
 jobs:
diff --git a/.npmrc b/.npmrc
@@ -0,0 +1,4 @@
+# Require the version of node specified in package.json to avoid
+# issues where the package-lock.json is generated with slightly
+# differing syntaxes between node versions.
+engine-strict=true
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -82,6 +82,9 @@
     "webpack-cli": "^5.1.4",
     "workbox-webpack-plugin": "^7.3.0"
   },
+  "engines": {
+    "node": "^24.0.0"
+  },
   "jest": {
     "roots": [
       "<rootDir>/openlibrary/plugins/openlibrary/js/",
diff --git a/scripts/install_nodejs.sh b/scripts/install_nodejs.sh
@@ -1,6 +1,6 @@
 # See https://github.com/nodesource/distributions#debian-and-ubuntu-based-distributions
 
-NODE_MAJOR=20
+NODE_MAJOR=24
 
 # Download and import the Nodesource GPG key
 apt-get install -y ca-certificates curl gnupg
