Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds request duration and response size information to HTTP metering so downstream meter providers can observe these metrics per request.
Changes:
- Extended
MeterEventto includeDurationandResponseSizefields for recording request timing and body size. - Updated the
WithMetermiddleware to time each request, wrap theResponseWriterto track bytes written, and populate the new fields on the emittedMeterEvent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/meters/mw.go | Times handler execution and wraps the ResponseWriter to capture status, duration, and response body size, passing these into the metering event. |
| server/meters/meters.go | Extends the MeterEvent struct with duration and response size fields so meter providers can consume the new metrics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds response duration and response size tracking to the HTTP metering middleware.
Changes
Duration(time.Duration) andResponseSize(int64) fields toMeterEventstructresponseWriterWrapperto track response body size by interceptingWritecallsWithMetermiddleware to measure request duration and capture response sizeThese metrics are recorded alongside existing HTTP-specific fields (
StatusCode,Success) for request observability.