Make Azure file verification optional reverify by download#559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Azure blob upload verification by replacing the broken
TransactionalValidationapproach with a download-and-compare method.Problem
The Azure SDK's
TransactionalValidationwithblob.TransferValidationTypeMD5()does not work correctly forUploadStreambecause it uploads files in chunks and validates MD5 against each chunk rather than the whole file.Solution
VerifyUploadfield or?verify_upload=truequery parameter in the storage URLmd5FromStreamis now the core function, withmd5FromReaderwrapping it for seekable readersChanges
az.go:
VerifyUploadfield toAzstruct?verify_upload=truequery parameter from URLblobimport, addbytesforbytes.Equalrequest.go:
md5FromReaderto usemd5FromStreamas coremd5Equalin favor ofbytes.Equalaz_test.go:
TestNewAzFromUrlwith comprehensive test cases for URL parsing includingverify_uploadparameterUsage