REST API: for single entity endpoints, return a 404 when no result#545
Merged
REST API: for single entity endpoints, return a 404 when no result#545
Conversation
Generated Code Check ✅All generated code is up to date. |
Contributor
|
@copilot regenerate review |
Contributor
|
@copilot can you provide an updated summary of all the changes in this PR, replacing the old summary you wrote originally |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@copilot summarize changes in this PR as a comment. DO NOT create a new issue or PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single entity REST endpoints (e.g.,
/feeds/{feed_id},/routes/{route_key}) now return HTTP 404 when the entity doesn't exist, instead of HTTP 200 with empty results. Collection endpoints continue to return HTTP 200 with empty arrays.Changes
Handler architecture
makeIndexHandler()(collections) andmakeEntityHandler()(single entities)SingleEntityfield from request structs—now determined by handler registrationFormat support
nilfor empty results to enable 404 responseOpenAPI schema
.format→.{format})Test coverage