Conversation
Generated Code Check ✅All generated code is up to date. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures DMFR commands from a flat namespace to a hierarchical structure, adds support for reading from stdin, and introduces new functionality for generating DMFR files from directories.
- Refactors
dmfr-formatanddmfr-lintcommands todmfr formatanddmfr lintsubcommands under a newdmfrparent command - Adds
dmfr from-dirsubcommand to generate DMFR registries from directories containing GTFS zip files - Implements stdin support for the sync command using
-argument - Adds
--dmfrflag to fetch and import commands for filtering by feed IDs from DMFR files - Adds
--secret-envflag to fetch command for specifying secrets via environment variables
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sync/sync_operator.go | Refactors error handling from if-else to switch statement for cleaner code |
| sync/sync.go | Adds support for pre-parsed registries from stdin and refactors to avoid duplicate file loading |
| schema/postgres/bootstrap.sh | Extends script to support importing GTFS feeds from directories or DMFR files during bootstrap |
| doc/cli/transitland_sync.md | Documents stdin support and provides usage examples |
| doc/cli/transitland_import.md | Documents new --dmfr flag |
| doc/cli/transitland_fetch.md | Documents new --dmfr and --secret-env flags |
| doc/cli/transitland_dmfr_lint.md | New documentation for dmfr lint subcommand |
| doc/cli/transitland_dmfr_from-dir.md | New documentation for dmfr from-dir subcommand |
| doc/cli/transitland_dmfr_format.md | New documentation for dmfr format subcommand |
| doc/cli/transitland_dmfr.md | New documentation for dmfr parent command |
| doc/cli/transitland_dmfr-lint.md | Removed (replaced by hierarchical structure) |
| doc/cli/transitland_dmfr-format.md | Removed (replaced by hierarchical structure) |
| doc/cli/transitland.md | Updates command reference to reflect new dmfr command structure |
| cmds/sync_cmd.go | Implements stdin support for reading DMFR from standard input |
| cmds/import_cmd.go | Adds --dmfr flag to filter imports by feed IDs from DMFR file |
| cmds/fetch_cmd.go | Adds --dmfr flag and --secret-env flag for environment variable-based secrets |
| cmds/dmfr_lint_cmd.go | Renames LintCommand to DmfrLintCommand |
| cmds/dmfr_from_dir_cmd.go | New command to generate DMFR from directory of GTFS files |
| cmds/dmfr_format_cmd.go | Renames FormatCommand to DmfrFormatCommand |
| cmds/dmfr_cmd.go | New parent command for DMFR subcommands |
| cmds/aliases.go | Provides backwards compatibility aliases for renamed commands |
| cmd/transitland/main.go | Updates command registration to use new hierarchical structure with hidden aliases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.