Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the tt.Seconds type's Scan method and corrects the time window presence check in StopTime validation. The primary issue was that empty strings were being incorrectly parsed as midnight (00:00:00) instead of being treated as "not provided". Additionally, the time window validation logic incorrectly required values greater than zero, which would have excluded valid midnight times.
Key Changes:
- Added early return for empty strings in
Seconds.Scanto properly handle unprovided time fields - Simplified
hasTimeWindowlogic to check only theValidflag, allowing zero values (midnight) to be correctly recognized as valid time windows
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tt/seconds.go | Adds empty string check in Scan method to return early with Valid=false, preventing empty strings from being parsed as midnight |
| gtfs/stop_time.go | Removes Val > 0 condition from hasTimeWindow check to correctly identify time windows that include midnight (value 0) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.