Improve rules/filters/validator/bestpractices organization#528
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the codebase structure for better organization of validation rules, filters, and related functionality. The main architectural change moves validation and transformation logic into dedicated extension packages under the ext/ directory hierarchy.
Key Changes:
- Best practice validation rules moved from
rulespackage toext/bestpracticespackage - Filter implementations moved from
filterspackage toext/filterspackage - Unimplemented TODO rules consolidated into new
ext/todopackage - Multiple new filter implementations added for GTFS data transformation
Reviewed changes
Copilot reviewed 42 out of 54 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| validator/validator.go | Updated imports to reference best practices from ext/bestpractices package |
| server/rest/feed_version_exporter.go | Updated import path for filters package |
| copier/copier.go | Updated import path for filters package |
| cmds/extract_cmd.go | Updated import path for filters package |
| cmd/transitland/main.go | Updated import path for filters package |
| rules/invalid_*.go | Removed stub files (moved to ext/todo) |
| rules/flex_validation_test.go | Removed test (moved to ext/bestpractices) |
| ext/todo/*.go | New package for unimplemented validation rules with updated package declarations |
| ext/bestpractices/*.go | Renamed from rules package with updated package declarations and new package documentation |
| ext/filters/*.go | New package containing filter implementations with registration in init() |
| ext/filters/basic_route_type_fliter.go | New basic route type conversion filter (filename contains typo) |
| ext/filters/prefix_filter.go | New prefix filter with bugs in FareRule field access |
| ext/filters/redate_filter.go | New calendar redate filter with parameter naming inconsistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.