Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the feed-state command to improve its structure and logging. The main change is replacing the SetActiveFeedVersions method with a new CalculateSetActiveChanges method that separates the calculation of changes from their execution.
- Replaced
SetActiveFeedVersionswithCalculateSetActiveChangesto calculate activation/deactivation changes without executing them - Restructured the command execution to run all operations within a single transaction
- Improved logging to show planned operations before execution and moved dry-run check after operation planning
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/feedstate/manager.go | Removed SetActiveFeedVersions method and added CalculateSetActiveChanges method that returns a FeedVersionChanges struct instead of directly executing changes |
| cmds/feed_state_cmd.go | Restructured command execution to calculate all changes upfront, moved transaction wrapping to encompass entire operation, and relocated dry-run check to after operation planning |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.