Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds materialized route geometries to improve spatial search capabilities. The implementation conditionally simplifies geometries in PostGIS while storing full geometries in SQLite.
Key Changes:
- Added a
SupportsSpatialFunctions()method to database adapters to differentiate PostGIS-enabled PostgreSQL from SQLite - Introduced
geometry_simplifiedcolumn to thetl_materialized_active_routestable with appropriate spatial indexing in PostgreSQL - Refactored materialization queries to use maps for column definitions, enabling conditional geometry processing
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tldb/adapter.go | Added SupportsSpatialFunctions() interface method |
| tldb/postgres/postgres.go | Implemented spatial functions support returning true for PostGIS |
| tldb/sqlite/sqlite.go | Implemented spatial functions support returning false |
| schema/postgres/migrations/20251021000001_add_route_geometry_columns.up.pgsql | Added geometry column and spatial index to materialized routes table |
| schema/sqlite/sqlite.sql | Added geometry_simplified BLOB column to materialized routes table |
| internal/feedstate/manager.go | Refactored materialization logic to support conditional geometry simplification |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.