Config option to use materialized views for active entities#518
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configuration option to use materialized views for querying active GTFS entities (agencies, routes, and stops), which can improve query performance by pre-computing the active entity set.
- Adds
UseMaterializedboolean flag to the Config struct - Updates entity finder methods to conditionally use materialized view tables when both active filtering and the new flag are enabled
- Introduces
UseActivestruct to pass both the active state and materialized view preference through the query builders
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/model/config.go | Adds UseMaterialized configuration field |
| cmds/server_cmd.go | Adds command-line flag and wires it to the Config |
| server/finders/dbfinder/finder.go | Defines UseActive struct to encapsulate active state and materialized view usage |
| server/finders/dbfinder/stop.go | Updates stop queries to use materialized views when configured |
| server/finders/dbfinder/route.go | Updates route queries to use materialized views when configured |
| server/finders/dbfinder/agency.go | Updates agency queries to use materialized views when configured |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
server/finders/dbfinder/route.go
Outdated
| func routeSelect(limit *int, after *model.Cursor, ids []int, useActive *UseActive, permFilter *model.PermFilter, where *model.RouteFilter) sq.SelectBuilder { | ||
| routeTable := "gtfs_routes" | ||
| active := useActive != nil && useActive.Active | ||
| if active && useActive != nil && useActive.UseMaterialized { |
There was a problem hiding this comment.
The condition useActive != nil is redundant in line 188 since it's already checked in line 187 where active is set. Line 188 can be simplified to if active && useActive.UseMaterialized {.
Suggested change
| if active && useActive != nil && useActive.UseMaterialized { | |
| if active && useActive.UseMaterialized { |
Generated Code Check ✅All generated code is up to date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.