Merged
Conversation
Generated Code Check ✅All generated code is up to date. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a feed state management system to handle active feed versions and maintain materialized tables for improved query performance. It provides centralized control over feed version activation/deactivation and creates denormalized cache tables for routes, stops, and agencies.
Key changes:
- New
feedstate.Managercomponent for managing feed state and materialized tables - Materialized tables (
tl_materialized_active_routes,tl_materialized_active_stops,tl_materialized_active_agencies) to cache active entity data - CLI command
feed-statefor manual feed state management operations
Reviewed Changes
Copilot reviewed 34 out of 35 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| schema/sqlite/sqlite.sql | Adds textsearch columns to GTFS tables and creates three new materialized tables for caching active routes, stops, and agencies |
| schema/postgres/migrations/20251020000001_materialized_index.up.pgsql | PostgreSQL migration creating the same materialized tables with appropriate indexes |
| internal/feedstate/manager.go | Core feed state manager implementing activation/deactivation logic and materialized table operations |
| internal/feedstate/manager_test.go | Comprehensive test suite covering all manager operations |
| importer/importer.go | Updates activation logic to use the new feed state manager |
| importer/unimporter.go | Updates deactivation logic to use the new feed state manager |
| cmds/feed_state_cmd.go | New CLI command for managing feed state operations |
| cmd/transitland/main.go | Registers the new feed-state command |
| doc/cli/*.md | Auto-generated documentation updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.