Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances geography buffer functionality by adding dataset filtering support to census data operations. The changes enable more precise querying by allowing users to specify a particular census dataset when filtering geography data.
- Added dataset parameter to census geography filters and corresponding GraphQL schema
- Updated census value loading to include dataset filtering with null safety checks
- Refactored buffer query logic to improve performance with proper CTE usage and simplified join structure
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/model/models_gen.go | Added optional Dataset field to CensusDatasetGeographyFilter struct |
| server/model/finders.go | Updated CensusValuesByGeographyIDs method signature to include dataset parameter |
| server/gql/loaders.go | Modified loader to handle dataset parameter with null safety and updated parameter structure |
| server/finders/dbfinder/finder.go | Removed unused checkRange function |
| server/finders/dbfinder/census.go | Enhanced geography queries with dataset filtering, improved buffer logic, and optimized database operations |
| schema/graphql/schema.graphqls | Added dataset input field to CensusDatasetGeographyFilter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes interline-io/calact-network-analysis-tool#145