Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit validation support for greater than (gt), greater than or equal (gte), less than (lt), and less than or equal (lte) checks, replacing the previous range-based validation approach. The changes introduce more granular comparison operators for field validation.
- Replaces RangeMin/RangeMax fields with four specific comparison operators (gt, gte, lt, lte)
- Updates validation logic to handle the new comparison operators with appropriate error messages
- Migrates existing range validation usage to use the new gte operator
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tt/reflect_test.go | Adds comprehensive test coverage for the new gt, gte, lt, and lte validation operators |
| tt/reflect.go | Updates validation logic to support the four new comparison operators and adds helper function |
| internal/tags/tags.go | Refactors FieldInfo struct and tag parsing to support the new comparison operators |
| gtfs/pathway.go | Migrates from range-based validation to the new comparison operators |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.