Added includeChildren param to ToNamespace and ToNamespaceSingleton #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alls, cleaned up documentation.
intentor
approved these changes
Mar 7, 2017
intentor
reviewed
Mar 7, 2017
| /// <returns>The binding condition object related to this binding.</returns> | ||
| public IBindingConditionFactory ToNamespaceSingleton(string namespaceName, bool includeChildren) | ||
| { | ||
| return this.ToNamespace(namespaceName, BindingInstance.Singleton, false); |
Owner
There was a problem hiding this comment.
Here includeChildren was not added. However, I'll fix it after merge.
intentor
reviewed
Mar 7, 2017
| /// <param name="includeChildren">Indicates whether child namespaces should be included.</param> | ||
| /// <returns>The binding condition object related to this binding.</returns> | ||
| public IBindingConditionFactory ToNamespace(string namespaceName, bool includeChildren) | ||
| { |
Owner
There was a problem hiding this comment.
Adic's source code uses curly braces on the same line as declarations. I'll format it when merged.
intentor
reviewed
Mar 7, 2017
|
|
||
| namespace Adic.Binding { | ||
| //// <summary> | ||
| /// <summary> |
Owner
There was a problem hiding this comment.
Thank you! 👍
I also fixed the same issue on other files.
intentor
added a commit
that referenced
this pull request
Mar 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing as
TypeUtils.GetAssignableTypessupported the includeChildren parameter it made sense to expose this functionality in theToNamespaceandToNamespaceSingletoncalls. I also did a quick cleanup of the documentation while I was in there.