Skip to content

Fixes #584: replace Enum with django.models.TextChoices#598

Merged
eshaan7 merged 8 commits intodevelop-2from
enum-changes
Aug 2, 2021
Merged

Fixes #584: replace Enum with django.models.TextChoices#598
eshaan7 merged 8 commits intodevelop-2from
enum-changes

Conversation

@m0mosenpai
Copy link
Member

@m0mosenpai m0mosenpai commented Jul 29, 2021 •
edited
Loading

Description

  • Replace Enum with TextChoices
  • Remove .name and .value occurrences
  • Test changes

Related issues

#584

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • The tests gave 0 errors.
  • Black gave 0 errors.
  • Flake gave 0 errors.

@m0mosenpai m0mosenpai added this to the v3.0 milestone Jul 29, 2021
@m0mosenpai m0mosenpai self-assigned this Jul 29, 2021
@m0mosenpai m0mosenpai linked an issue Jul 29, 2021 that may be closed by this pull request
[v3] Replace enum with models.TextChoices #584
Closed
@m0mosenpai m0mosenpai marked this pull request as ready for review July 29, 2021 14:04
eshaan7
eshaan7 reviewed Jul 29, 2021
View reviewed changes
eshaan7
eshaan7 reviewed Jul 29, 2021
View reviewed changes
eshaan7
eshaan7 reviewed Jul 29, 2021
View reviewed changes
eshaan7
eshaan7 reviewed Jul 29, 2021
View reviewed changes
eshaan7
eshaan7 reviewed Jul 29, 2021
View reviewed changes
eshaan7
eshaan7 reviewed Jul 29, 2021
View reviewed changes
eshaan7
eshaan7 reviewed Jul 29, 2021
View reviewed changes
eshaan7
eshaan7 reviewed Jul 29, 2021
View reviewed changes
eshaan7
eshaan7 reviewed Jul 29, 2021
View reviewed changes
@eshaan7 eshaan7 marked this pull request as draft July 29, 2021 16:04
@eshaan7 eshaan7 removed this from the v3.0 milestone Jul 30, 2021
eshaan7
eshaan7 reviewed Jul 30, 2021
View reviewed changes
@m0mosenpai m0mosenpai marked this pull request as ready for review July 30, 2021 09:20
@intelowlproject intelowlproject deleted a comment from lgtm-com bot Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 31, 2021

Codecov Report

Merging #598 (a81cf84) into develop-2 (0f3c2b5) will not change coverage.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop-2     #598   +/-   ##
==========================================
  Coverage      63.77%   63.77%           
==========================================
  Files             14       14           
  Lines            588      588           
  Branches          63       63           
==========================================
  Hits             375      375           
  Misses           186      186           
  Partials          27       27
Impacted Files Coverage Δ
api_app/connectors_manager/controller.py 32.75% <0.00%> (ø)
api_app/core/views.py 43.90% <0.00%> (ø)
api_app/analyzers_manager/controller.py 38.75% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f3c2b5...a81cf84. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2021

This pull request fixes 1 alert when merging a81cf84 into 0f3c2b5 - view on LGTM.com

fixed alerts:

  • 1 for Unhashable object hashed

@eshaan7 eshaan7 merged commit 1d523aa into develop-2 Aug 2, 2021
@eshaan7 eshaan7 deleted the enum-changes branch August 2, 2021 08:05
@eshaan7
Copy link
Member

eshaan7 commented Aug 2, 2021

Thank you!

@intelowlproject intelowlproject deleted a comment from lgtm-com bot Aug 5, 2021
@intelowlproject intelowlproject deleted a comment from lgtm-com bot Aug 5, 2021
federicofantini pushed a commit that referenced this pull request Aug 20, 2024
@carellamartina @mlodic
@drosetti @0ssigeno @fgibertoni @dependabot @code-review-doctor @shivam-Purohit @moonpatel @cristinaascari @ip2location @suryapavan1611 @g4ze @agnorance
'Private_Passive_DNS' playbook + 'Quokka - Passive DNS' page (#598)
c309036 
* Vulners#1257 (#2340)

* vulners

* vulners wrapper

* docs

* lesser variables

* migrations

* code quality

* migration

* code

---------

Co-authored-by: g4ze <[email protected]>

* bump 6.0.3

* bump 6.0.3

* updated docs

* Bump django-ses from 4.0.0 to 4.1.0 in /requirements (#2342)

Bumps [django-ses](https://github.com/django-ses/django-ses) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/django-ses/django-ses/releases)
- [Changelog](https://github.com/django-ses/django-ses/blob/main/CHANGES.md)
- [Commits](django-ses/django-ses@v4.0.0...v4.1.0)

---
updated-dependencies:
- dependency-name: django-ses
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* migrate (#2353)

Co-authored-by: g4ze <[email protected]>

* incrementing uwsgi start-up period to due to migration time

* adjusting doc + https nginx file

* ailtyposquatting (#2341)

* ailtyposquatting

* restore a file that was deleted

* fix

* fix

* changes

* tests

* no files

* logs

* files

* variables

* test

* test

* enum

* tests

* tests

* dns_resolve

* migration

* a log :p

---------

Co-authored-by: g4ze <[email protected]>

* supported sh tld

* bump

* removed initialize.sh from start script

* Fix phoneinfoga name

Signed-off-by: 0ssigeno <[email protected]>

* Start with --traefik/--traefik_local option. Closes #2305 (#2351)

* add traefik config and options for dev and prod

working config with traefik

finish traefik config prod/dev

add documentation

* Update traefik_local.override.yml - remove comment

* rework prod/local traefik and add deletion of get-docker.sh

* split traefik compose into base, prod and local

* remove print of compose files

* parent c45c84a
author David Mihajlovic <[email protected]> 1716908101 +0200
committer David Mihajlovic <[email protected]> 1717135119 +0200

add traefik config and options for dev and prod

working config with traefik

finish traefik config prod/dev

add documentation

Vulners#1257 (#2340)

* vulners

* vulners wrapper

* docs

* lesser variables

* migrations

* code quality

* migration

* code

---------

Co-authored-by: g4ze <[email protected]>

bump 6.0.3

updated docs

Bump django-ses from 4.0.0 to 4.1.0 in /requirements (#2342)

Bumps [django-ses](https://github.com/django-ses/django-ses) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/django-ses/django-ses/releases)
- [Changelog](https://github.com/django-ses/django-ses/blob/main/CHANGES.md)
- [Commits](django-ses/django-ses@v4.0.0...v4.1.0)

---
updated-dependencies:
- dependency-name: django-ses
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

rework prod/local traefik and add deletion of get-docker.sh

split traefik compose into base, prod and local

get-docker.sh deletion without sudo

change traefik compose naming

* remove unnecessary files

* remove print of compose files

* change doc

---------

Co-authored-by: Ubuntu <[email protected]>

* Fix url

Signed-off-by: 0ssigeno <[email protected]>

* Visualizer improvements (#2366)

* table visualizer improvements

* adjusted tests

* prettier

* changes

* fixed start script

* Split folder creation into two parts removing sudo (#2373)

* Bump elasticsearch-dsl from 8.13.0 to 8.14.0 in /requirements (#2370)

Bumps [elasticsearch-dsl](https://github.com/elasticsearch/elasticsearch-dsl-py) from 8.13.0 to 8.14.0.
- [Release notes](https://github.com/elasticsearch/elasticsearch-dsl-py/releases)
- [Changelog](https://github.com/elastic/elasticsearch-dsl-py/blob/main/Changelog.rst)
- [Commits](elastic/elasticsearch-dsl-py@v8.13.0...v8.14.0)

---
updated-dependencies:
- dependency-name: elasticsearch-dsl
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump quark-engine from 24.5.1 to 24.6.1 in /requirements (#2371)

Bumps [quark-engine](https://github.com/quark-engine/quark-engine) from 24.5.1 to 24.6.1.
- [Release notes](https://github.com/quark-engine/quark-engine/releases)
- [Commits](ev-flow/quark-engine@v24.5.1...v24.6.1)

---
updated-dependencies:
- dependency-name: quark-engine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Auto creation default test user with debug=true#1189 (#2369)

* create super user

* env files :p

---------

Co-authored-by: Matteo Lodi <[email protected]>
Co-authored-by: g4ze <[email protected]>

* Bump library/nginx from 1.26.0-alpine to 1.27.0-alpine in /docker (#2358)

Bumps library/nginx from 1.26.0-alpine to 1.27.0-alpine.

---
updated-dependencies:
- dependency-name: library/nginx
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump authlib from 1.3.0 to 1.3.1 in /requirements (#2368)

Bumps [authlib](https://github.com/lepture/authlib) from 1.3.0 to 1.3.1.
- [Release notes](https://github.com/lepture/authlib/releases)
- [Changelog](https://github.com/lepture/authlib/blob/master/docs/changelog.rst)
- [Commits](authlib/authlib@v1.3.0...v1.3.1)

---
updated-dependencies:
- dependency-name: authlib
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Matteo Lodi <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* detect-it-easy analyzer, closes #1590 (#2354)

* die

* tweeks

* codefactor

* codefactor

* ypo

* gitignore

* typo fix

* detectiteasyyyyy

* tests

* supported files

* msdos

* logs, file support, soft t/o, poll

* migrate

* for all files

* docker_based_true

* params

* tests debug[1]

* Update api_app/analyzers_manager/migrations/0094_analyzer_config_detectiteasy.py

* Update api_app/analyzers_manager/file_analyzers/detectiteasy.py

---------

Co-authored-by: g4ze <[email protected]>
Co-authored-by: Matteo Lodi <[email protected]>

* Bi update (#2326)

* added bi document

* update bi interface

* update bi interface

* fix bi serializer

* update certego-saas version

* mign fix (#2375)

Co-authored-by: g4ze <[email protected]>

* watchman adjusts test (#2349)

* watchman adjusts test

* watchman right version

* test

* adjust

* right watchman version

* Malprob analyzer, closes #1521 (#2357)

* init

updates

works, weirdly

new flow

updates

tests

deepsrc

* tests

* disable_ratelimit(), t/o

* timeout,reform response,TLP:CLEAR,logs,no raise,disableRatelimit

* migrations

* reponse format

* t/o

* t/o(agn)

* api_key

* ratelimit,migrations,healthcheck

---------

Co-authored-by: g4ze <[email protected]>

* Passive_DNS playbook and visualizer (#2374)

* created 'passive_dns' playbook and visualizer

* dnsdb

* validin

* changes

* refactor

* changes

* refactor + tests

* changes

* changes

* added private_passive_dns playbook and visualizer

* tests

* changes

* changes

* added test

---------

Signed-off-by: 0ssigeno <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Shivam Purohit <[email protected]>
Co-authored-by: Matteo Lodi <[email protected]>
Co-authored-by: Daniele Rosetti <[email protected]>
Co-authored-by: 0ssigeno <[email protected]>
Co-authored-by: Daniele Rosetti <[email protected]>
Co-authored-by: fgibertoni <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Simone Berni <[email protected]>
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
Co-authored-by: Shivam Purohit <[email protected]>
Co-authored-by: Moon Patel <[email protected]>
Co-authored-by: Cristina Ascari <[email protected]>
Co-authored-by: IP2Location <[email protected]>
Co-authored-by: suryapavan1611 <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: Nilay Gupta <[email protected]>
Co-authored-by: g4ze <[email protected]>
Co-authored-by: David Mihajlovic <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eshaan7 eshaan7 eshaan7 approved these changes

Assignees

@m0mosenpai m0mosenpai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v3] Replace enum with models.TextChoices

2 participants

@m0mosenpai @eshaan7