Skip to content

adding missing migration#531

Merged
mlodic merged 1 commit intodevelopfrom
migration_for_durin
Jul 14, 2021
Merged

adding missing migration#531
mlodic merged 1 commit intodevelopfrom
migration_for_durin

Conversation

@mlodic
Copy link
Member

@mlodic mlodic commented Jul 14, 2021

added makemigrations for durin package only to allow customization of its parameters.

@eshaan7 do you think there is a cleanest way to do this? maybe directly in the durin package?

In this way the durin migration would be applied each time the IntelOwl project is brought up. Not of a big problem but still unecessary

@mlodic mlodic requested a review from eshaan7 July 14, 2021 08:15
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #531 (b0214c7) into develop (aa8820f) will increase coverage by 1.83%.
The diff coverage is 70.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #531      +/-   ##
===========================================
+ Coverage    66.75%   68.58%   +1.83%     
===========================================
  Files           95      104       +9     
  Lines         3706     4078     +372     
  Branches       519      579      +60     
===========================================
+ Hits          2474     2797     +323     
- Misses         941      944       +3     
- Partials       291      337      +46     
Impacted Files Coverage Δ
api_app/crons.py 70.27% <ø> (ø)
api_app/helpers.py 60.00% <ø> (ø)
api_app/permissions.py 100.00% <ø> (ø)
api_app/script_analyzers/file_analyzers/apkid.py 100.00% <ø> (ø)
..._app/script_analyzers/file_analyzers/boxjs_scan.py 100.00% <ø> (ø)
...i_app/script_analyzers/file_analyzers/capa_info.py 100.00% <ø> (ø)
...pi_app/script_analyzers/file_analyzers/doc_info.py 50.00% <ø> (ø)
api_app/script_analyzers/file_analyzers/floss.py 77.41% <ø> (ø)
...pp/script_analyzers/file_analyzers/intezer_scan.py 68.42% <ø> (ø)
...pi_app/script_analyzers/file_analyzers/manalyze.py 100.00% <ø> (ø)
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f1c4c0...b0214c7. Read the comment docs.

@eshaan7
Copy link
Member

eshaan7 commented Jul 14, 2021

Unfortunately, the way the durin settings are configured makes migrations a bit painful. At the moment, I have no elegant solution other than what you implemented.

@mlodic mlodic merged commit c1f43a2 into develop Jul 14, 2021
@eshaan7 eshaan7 deleted the migration_for_durin branch August 27, 2021 07:51
federicofantini pushed a commit that referenced this pull request Aug 20, 2024
Added config independent from env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants