Fix upload limit. Fixes #3156#3174
Merged
mlodic merged 8 commits intointelowlproject:developfrom Jan 27, 2026
Merged
Conversation
Contributor
|
Hey, please read the full contribution guidelines and adjust the PR accordingly, thanks. |
Contributor
Author
|
could you please review again! |
mlodic
requested changes
Jan 13, 2026
Member
mlodic
left a comment
mlodic
left a comment
There was a problem hiding this comment.
you need to keep the PR template, compile it and show proof that this change works.
intel_owl/settings/security.py
Outdated
| DATA_UPLOAD_MAX_MEMORY_SIZE = 50 * (10**6) | ||
| FILE_UPLOAD_MAX_MEMORY_SIZE = 50 * (10**6) | ||
| DATA_UPLOAD_MAX_MEMORY_SIZE = 100 * 1024 * 1024 | ||
| FILE_UPLOAD_MAX_MEMORY_SIZE = 100 * 1024 * 1024 |
Member
There was a problem hiding this comment.
why change from exponential? keep it consistent please
fixed the concistecy
Contributor
Author
|
fixed the consistency, if the code is run to the docker, it must work correctly |
Member
|
you still didn't provide proof of this working as expected, "it must work" doesn't mean anything. |
|
This pull request has been marked as stale because it has had no activity for 10 days. If you are still working on this, please provide some updates or it will be closed in 5 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix large file upload failures caused by mismatched backend limits.
This PR fixes an issue where file uploads larger than 50MB would silently fail.
Although nginx was configured to allow uploads up to 100MB, Django backend settings
(
DATA_UPLOAD_MAX_MEMORY_SIZEandFILE_UPLOAD_MAX_MEMORY_SIZE) were limited to 50MB,causing requests to be rejected before processing.
Fixes #3156
What changed
DATA_UPLOAD_MAX_MEMORY_SIZEFILE_UPLOAD_MAX_MEMORY_SIZEType of change
Checklist
developBlack,Flake,Isort) gave 0 errors.testsfolder).Notes