Skip to content

Fix: Correct X-End-Of-Life-Date header in deprecated_endpoint decorator. Closes #3109#3111

Merged
fgibertoni merged 2 commits intointelowlproject:developfrom
rootp1:fix/issue-3109
Dec 16, 2025
Merged

Fix: Correct X-End-Of-Life-Date header in deprecated_endpoint decorator. Closes #3109#3111
fgibertoni merged 2 commits intointelowlproject:developfrom
rootp1:fix/issue-3109

Conversation

@rootp1
Copy link
Contributor

@rootp1 rootp1 commented Dec 10, 2025

Fixed a bug in the deprecated_endpoint decorator where the X-End-Of-Life-Date response header was incorrectly assigned the value of deprecation_date instead of end_of_life_date.

This was a simple copy-paste error on line 36 of api_app/decorators.py that caused API consumers to receive incorrect information about when deprecated endpoints would actually be removed.

response.headers["X-End-Of-Life-Date"] = deprecation_date  #before
response.headers["X-End-Of-Life-Date"] = end_of_life_date  #after

Impact: API consumers can now properly plan their migrations with accurate deprecation timelines.

Type of change

  • Bug fix

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • Linters (Black, Flake, Isort) gave 0 errors.

@rootp1
Copy link
Contributor Author

rootp1 commented Dec 16, 2025

@fgibertoni what am i supposed to do since the test failed, we just changed a value of a variable

@fgibertoni
Copy link
Contributor

I think there's another issue, not related to your PR.

@fgibertoni fgibertoni merged commit 3347dc3 into intelowlproject:develop Dec 16, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants