Skip to content

Analyzable overview page#2883

Merged
drosetti merged 11 commits intofrontend_analyzablesfrom
analyzable_overview
Jun 10, 2025
Merged

Analyzable overview page#2883
drosetti merged 11 commits intofrontend_analyzablesfrom
analyzable_overview

Conversation

@carellamartina
Copy link
Contributor

@carellamartina carellamartina commented Jun 4, 2025

(Please add to the PR name the issue/s that this PR would close if merged by using a Github keyword. Example: <feature name>. Closes #999. If your PR is made by a single commit, please add that clause in the commit too. This is all required to automate the closure of related issues.)

Description

Please include a summary of the change and link to the related issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
    • I strictly followed the documentation "How to create a Plugin"
    • Usage file was updated. A link to the PR to the docs repo has been added as a comment here.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration). A link to the PR to the docs repo has been added as a comment here.
    • I have dumped the configuration from Django Admin using the dumpplugin command and added it in the project as a data migration. ("How to share a plugin with the community")
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require any API key), please add it in the FREE_TO_USE_ANALYZERS playbook by following this guide.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
    • If the plugin interacts with an external service, I have created an attribute called precisely url that contains this information. This is required for Health Checks (HEAD HTTP requests).
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • I have added that raw JSON sample to the MockUpResponse of the _monkeypatch() method. This serves us to provide a valid sample for testing.
    • I have created the corresponding DataModel for the new analyzer following the documentation
  • I have inserted the copyright banner at the start of the file: # This file is a part of IntelOwl https://github.com/intelowlproject/IntelOwl # See the file 'LICENSE' for copying permission.
  • Please avoid adding new libraries as requirements whenever it is possible. Use new libraries only if strictly needed to solve the issue you are working for. In case of doubt, ask a maintainer permission to use a specific library.
  • If external libraries/packages with restrictive licenses were added, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.
  • After you had submitted the PR, if DeepSource, Django Doctors or other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review by using GitHub's reviewing system detailed here.

@carellamartina carellamartina requested a review from drosetti June 4, 2025 10:50
@mlodic
Copy link
Member

mlodic commented Jun 4, 2025

screenshot please? ❤️

@carellamartina
Copy link
Contributor Author

carellamartina commented Jun 4, 2025

image

drosetti
drosetti requested changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@drosetti drosetti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good! Just a few minor things to change. The comments in the code and also:

There is a problem with the tag: the string is truncated, but I think it's a problem in the backend in the AbuseIPDB analyzer.
In case you run an analysis with no playbook it's displayed: Playbook executed: null I suggest to change to the same string in the job table ("Custom Analysis", if I remember correctly).

@carellamartina carellamartina requested a review from drosetti June 9, 2025 14:20
drosetti
drosetti requested changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@drosetti drosetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to create an enum for the job/user_report in the AnalyzerOverview. Just to avoid typos that could lead to errors.

@carellamartina carellamartina requested a review from drosetti June 10, 2025 08:56
drosetti
drosetti requested changes Jun 10, 2025
View reviewed changes
frontend/src/components/analyzables/result/analyzablesHistoryTableColumns.jsx Outdated
id={`analyzable-history__${original.type}-${id}`}
// to be modified with the correct url when the dedicated page will be created
href={
original.type === "job"
Copy link
Contributor

@drosetti drosetti Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the enum :P

@drosetti drosetti self-requested a review June 10, 2025 09:10
@drosetti drosetti merged commit 96892b7 into frontend_analyzables Jun 10, 2025
4 checks passed
@drosetti drosetti deleted the analyzable_overview branch June 10, 2025 09:11
drosetti added a commit that referenced this pull request Jul 31, 2025
@carellamartina @drosetti
Frontend - analyzables page + user events modal (#2931)
8de0446 
* Frontend - Analyzables page (#2865)

* adjusted menu

* analyzables page draft + refactor

* adjusted table columns and serializer

* frontend tests

* tests

* prettier

* fix

* changes

* fix

* Analyzable overview page (#2883)

* analyzable overview page draft

* refactor

* visualizers draft

* Analyzable overview page

* prettier

* removed cache

* changes

* adjusted tests

* fixed decay date visualizer

* use enum

---------

Co-authored-by: drosetti <[email protected]>

* added data model tab (#2900)

* Added 'user reports' in the history page (#2895)

* added user-reports page

* fix

* changes

* tests

* changes

* prettier

* fixed decayed badge

* fix

* User events modal form (#2928)

* form draft

* adjusted backend

* adjusted analyzable history

* fix

* fixed evaluation modal

* renamed user reports to user events

* renamed analyzable to artifact in the gui

* adjusted frontend tests

* fix

* frontend tests

* fix frontend tests

* prettier

* fix

* fix

* fix

* refactor history tables

* fix

---------

Co-authored-by: drosetti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drosetti drosetti drosetti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carellamartina @mlodic @drosetti