Search investigation by observable#2671
Conversation
carellamartina
left a comment
There was a problem hiding this comment.
I found a bug in the time picker: if I go to the history page, perform a new analysis from the scan page and then return to the history page, the value of the time picker remains the previous one so the new investigation or new jobs are not shown
|
This pull request has been marked as stale because it has had no activity for 10 days. If you are still working on this, please provide some updates or it will be closed in 5 days. |
carellamartina
left a comment
There was a problem hiding this comment.
I suggest changing the behavior of the time picker on the history page. Now if you visit the page after a scan and in case of refresh the values are not modified but I think it is better that the time picker always updates to the default value (1 day) taking the current time as the final value.
Only in case of manual change is it correct that the value remains fixed.
|
I did these fixes:
I didn't change the refresh behaviour: I think it's correct the time range in the url is preserved (this is the same behaviour of other projects), also I think this could be quite difficult to handle and didn't worth the effort. |
(Please add to the PR name the issue/s that this PR would close if merged by using a Github keyword. Example:
<feature name>. Closes #999. If your PR is made by a single commit, please add that clause in the commit too. This is all required to automate the closure of related issues.)Description
Please include a summary of the change and link to the related issue.
Type of change
Please delete options that are not relevant.
Checklist
developdumpplugincommand and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zipand you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERSplaybook by following this guide.urlthat contains this information. This is required for Health Checks._monkeypatch()was used in its class to apply the necessary decorators.MockUpResponseof the_monkeypatch()method. This serves us to provide a valid sample for testing.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.DeepSource,Django Doctorsor other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.Important Rules