Merged
Conversation
# Conflicts: # requirements/project-requirements.txt
…l-phishing-analysis-framework
# Conflicts: # requirements/project-requirements.txt
…aybook-phishing-analysis
…hing_form_compiler.py Co-authored-by: Matteo Lodi <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
api_app/analyzers_manager/file_analyzers/phishing/phishing_form_compiler.py
Fixed
Show fixed
Hide fixed
| ) | ||
|
|
||
| logger.info( | ||
| f"Job #{self.job_id}: Sending value {value_to_set} for {input_name=}" |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI over 1 year ago
To fix the problem, we need to ensure that sensitive information such as passwords is not logged in clear text. Instead of logging the actual value of sensitive fields, we can log a placeholder or a generic message indicating that a sensitive value was processed. This way, we maintain the logging functionality without exposing sensitive data.
The best way to fix the problem without changing existing functionality is to modify the logging statements to exclude sensitive data. Specifically, we will replace the actual values of sensitive fields with a placeholder like "[REDACTED]" or a similar message.
Suggested changeset
1
api_app/analyzers_manager/file_analyzers/phishing/phishing_form_compiler.py
| @@ -140,3 +140,3 @@ | ||
| logger.info( | ||
| f"Job #{self.job_id}: Found hidden input tag with {input_name=} and {input_value=}" | ||
| f"Job #{self.job_id}: Found hidden input tag with {input_name=} and value [REDACTED]" | ||
| ) | ||
| @@ -157,5 +157,10 @@ | ||
|
|
||
| logger.info( | ||
| f"Job #{self.job_id}: Sending value {value_to_set} for {input_name=}" | ||
| ) | ||
| if input_type.lower() == "password": | ||
| logger.info( | ||
| f"Job #{self.job_id}: Sending value [REDACTED] for {input_name=}" | ||
| ) | ||
| else: | ||
| logger.info( | ||
| f"Job #{self.job_id}: Sending value {value_to_set} for {input_name=}" | ||
| ) | ||
| result.setdefault(input_name, value_to_set) | ||
| @@ -165,3 +170,4 @@ | ||
| params, dest_url = self.compile_form_field(form) | ||
| logger.info(f"Job #{self.job_id}: Sending {params=} to submit url {dest_url}") | ||
| redacted_params = {k: (v if k.lower() != "password" else "[REDACTED]") for k, v in params.items()} | ||
| logger.info(f"Job #{self.job_id}: Sending {redacted_params=} to submit url {dest_url}") | ||
| return requests.post( |
Copilot is powered by AI and may make mistakes. Always verify output.
Contributor
Author
…l-phishing-analysis-framework
mlodic
reviewed
Nov 5, 2024
mlodic
requested changes
Nov 5, 2024
integrations/phishing_analyzers/analyzers/seleniumwire_request_serializer.py
Outdated
Show resolved
Hide resolved
integrations/phishing_analyzers/analyzers/seleniumwire_request_serializer.py
Outdated
Show resolved
Hide resolved
integrations/phishing_analyzers/analyzers/seleniumwire_request_serializer.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a framework for dumping information about web pages and interact with phishing pages.
Type of change
Please delete options that are not relevant.
Checklist
developdumpplugincommand and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zipand you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERSplaybook by following this guide.urlthat contains this information. This is required for Health Checks._monkeypatch()was used in its class to apply the necessary decorators.MockUpResponseof the_monkeypatch()method. This serves us to provide a valid sample for testing.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.DeepSource,Django Doctorsor other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.Important Rules