Conversation
mlodic
requested changes
Jul 22, 2024
Member
mlodic
left a comment
mlodic
left a comment
There was a problem hiding this comment.
great changes! It would be cool if you could add a sample example of a successful extraction for all the cases you implemented as a test/confirmation that they work as expected.
…cument_urls_extraction
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…action # Conflicts: # requirements/project-requirements.txt
federicofantini
force-pushed
the
document_urls_extraction
branch
from
aa8cc25 to
7a977ec
Compare
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
federicofantini
force-pushed
the
document_urls_extraction
branch
from
51b8ce1 to
477638c
Compare
…action # Conflicts: # docs/source/Contribute.md # docs/source/Usage.md # requirements/project-requirements.txt
mlodic
requested changes
Aug 26, 2024
Member
mlodic
left a comment
mlodic
left a comment
There was a problem hiding this comment.
before merging, you need to rebuild the test_files.zip cause these 2 PRs will be merged before yours: #2461 and https://github.com/intelowlproject/IntelOwl/pull/2454/files
tests/api_app/analyzers_manager/file_analyzers/test_lnk_info.py
Outdated
Show resolved
Hide resolved
api_app/pivots_manager/migrations/0028_pivot_config_resubmitdownloadedfile.py
Outdated
Show resolved
Hide resolved
…action # Conflicts: # api_app/analyzers_manager/models.py # tests/test_files.zip
…cument_urls_extraction
Michalsus
pushed a commit
to standa4/IntelOwl
that referenced
this pull request
Oct 11, 2024
* document_urls_extraction * added tests and samples * fixed follina regex * fixed string delimiter in lnk files url extraction * fixed onenone test * fixed strings_info tests max chars * fixed migration number * added all test files * fixed XML attacks vuln * fixed deepsource warnings * removed subfolder zip test files * added missing supported filetypes Lnk_Info migration * added migration to lnk mimetype support * wrong tests names * fixed test_files path in CI * added --malware_tools_analyzers in CI for tests * removed CI malware analyzers because all_analyzers is present * added temporary --malware_tools_analyzers * added all analyzers just to make the tests pass * added all analyzers just to make the tests pass * added boxjs tests * disabled mockup connetions for boxjs and strings_info * fixed malware_analyzer_tools filename thug * fixed deepsource missing method * Manage missing directory Signed-off-by: 0ssigeno <[email protected]> * added missing pr contribution requirements * fixed typo * fixed typo * added test for iocextract analyzer * fixed pdf info without uris * fixed assertTrue member in list with assertIn * removed useless onenote playbook * added playbook uris extraction * Update pull_request_automation.yml * changed playbook to execute * reformatted * changed playbook to execute * added checks to load file data type * updated test files * made requested changes * fixed migration order * fixed migration order * fixed migration order * adjusted migrations, doc_info and others * linter * added conditional testing * added testif * added test for lnk file * trying adjusting CI * removed duplicated test * prevent test from failing when skipping unhealthy containers tests --------- Signed-off-by: 0ssigeno <[email protected]> Co-authored-by: 0ssigeno <[email protected]> Co-authored-by: Matteo Lodi <[email protected]>
vaclavbartos
pushed a commit
to standa4/IntelOwl
that referenced
this pull request
Oct 13, 2024
* document_urls_extraction * added tests and samples * fixed follina regex * fixed string delimiter in lnk files url extraction * fixed onenone test * fixed strings_info tests max chars * fixed migration number * added all test files * fixed XML attacks vuln * fixed deepsource warnings * removed subfolder zip test files * added missing supported filetypes Lnk_Info migration * added migration to lnk mimetype support * wrong tests names * fixed test_files path in CI * added --malware_tools_analyzers in CI for tests * removed CI malware analyzers because all_analyzers is present * added temporary --malware_tools_analyzers * added all analyzers just to make the tests pass * added all analyzers just to make the tests pass * added boxjs tests * disabled mockup connetions for boxjs and strings_info * fixed malware_analyzer_tools filename thug * fixed deepsource missing method * Manage missing directory Signed-off-by: 0ssigeno <[email protected]> * added missing pr contribution requirements * fixed typo * fixed typo * added test for iocextract analyzer * fixed pdf info without uris * fixed assertTrue member in list with assertIn * removed useless onenote playbook * added playbook uris extraction * Update pull_request_automation.yml * changed playbook to execute * reformatted * changed playbook to execute * added checks to load file data type * updated test files * made requested changes * fixed migration order * fixed migration order * fixed migration order * adjusted migrations, doc_info and others * linter * added conditional testing * added testif * added test for lnk file * trying adjusting CI * removed duplicated test * prevent test from failing when skipping unhealthy containers tests --------- Signed-off-by: 0ssigeno <[email protected]> Co-authored-by: 0ssigeno <[email protected]> Co-authored-by: Matteo Lodi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added URLs extraction and pivoting for each document downloaders file types.
Type of change
Please delete options that are not relevant.
Checklist
developdumpplugincommand and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zipand you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERSplaybook by following this guide.urlthat contains this information. This is required for Health Checks._monkeypatch()was used in its class to apply the necessary decorators.MockUpResponseof the_monkeypatch()method. This serves us to provide a valid sample for testing.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.DeepSource,Django Doctorsor other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.