Skip to content

added rule to short variable names#2026

Merged
drosetti merged 14 commits intodevelopfrom
linter
Dec 15, 2023
Merged

added rule to short variable names#2026
drosetti merged 14 commits intodevelopfrom
linter

Conversation

@drosetti
Copy link
Contributor

@drosetti drosetti commented Dec 13, 2023 •
edited
Loading

Description

Improved linting rules in the frontend

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
    • I strictly followed the documentation "How to create a Plugin"
    • Usage file was updated.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration).
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • I have dumped the configuration from Django Admin using the dumpplugin command and added it in the project as a data migration. [Doc]("How to create a Plugin")
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require API keys), please add it in the FREE_TO_USE_ANALYZERS playbook in playbook_config.json.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If changes were made to an existing model/serializer/view, the docs were updated and regenerated (check CONTRIBUTE.md).
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

@codecov
Copy link

codecov bot commented Dec 15, 2023 •
edited
Loading

Codecov Report

Merging #2026 (889426b) into develop (aa8820f) will increase coverage by 8.93%.
Report is 1568 commits behind head on develop.
The diff coverage is 75.46%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2026      +/-   ##
===========================================
+ Coverage    66.75%   75.68%   +8.93%     
===========================================
  Files           95      464     +369     
  Lines         3706    13825   +10119     
  Branches       519     1431     +912     
===========================================
+ Hits          2474    10464    +7990     
- Misses         941     2800    +1859     
- Partials       291      561     +270
Files Coverage Δ
api_app/analyzers_manager/admin.py 100.00% <100.00%> (ø)
api_app/analyzers_manager/apps.py 100.00% <100.00%> (ø)
api_app/analyzers_manager/constants.py 100.00% <100.00%> (ø)
api_app/analyzers_manager/exceptions.py 100.00% <100.00%> (ø)
...app/analyzers_manager/file_analyzers/boxjs_scan.py 100.00% <100.00%> (ø)
...pi_app/analyzers_manager/file_analyzers/onenote.py 100.00% <100.00%> (ø)
...pi_app/analyzers_manager/file_analyzers/peframe.py 82.35% <100.00%> (ø)
...i_app/analyzers_manager/file_analyzers/rtf_info.py 48.64% <100.00%> (ø)
...s_manager/file_analyzers/xlm_macro_deobfuscator.py 62.50% <100.00%> (ø)
api_app/analyzers_manager/filters.py 100.00% <100.00%> (ø)
... and 236 more

... and 274 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e4a481...889426b. Read the comment docs.

@drosetti drosetti merged commit f729f48 into develop Dec 15, 2023
@drosetti drosetti deleted the linter branch December 15, 2023 11:30
mlodic added a commit that referenced this pull request Dec 27, 2023
@mlodic @drosetti
@0ssigeno @carellamartina @fgibertoni @dependabot @code-review-doctor
Merge pull request #2041 from intelowlproject/develop
872b113 
* added book icon

* Fix md

Signed-off-by: 0ssigeno <[email protected]>

* Adjusted toasts  (#2015)

* adjusted toast

* fix test

---------

Co-authored-by: Daniele Rosetti <[email protected]>

* updated flare-floss to v3

* updated flare-floss to v3.0.1

* fixed the doc about contribute

* fixed unresponsive scan page form with large files

* changed social button popover trigger

* fixed order problem in visualizer tabs

* fixed PR template

* fixed PR template

* Frontend - HealthCheck and Pull buttons (#2025)

* added healthcheck and pull button

* test draft

* frontend tests

* adjusted toasts

* added rule to short variable names (#2026)

* added rule to short variable names

* fix

* fixed rules

* fixed rules

* added todo comment

* fix

* added note

* fixed short var names

* fixes

* fix

* fix

* fix

* comment

* #1990 DNS0 /names Analyzer (#2024)

* First not tested prototype

* Added _monkeypatch() skeleton

* Fixed a wrong condition in parameter validation

* Added config() function to prepare data for request

* Added hasattr() check for attributes

* First successful run

- Added check on existence of API parameter
- Added authorization header
- Added checks on parameters existence

* Fix _api_name parameter check

* Fixed parameter configuration

* Removed unused if statement

* Added support for UNIX timestamps and relative dates

* Renamed dns0 service to separate services

* Completed checks for not set parameters

* Added checks of existence for all parameters

* Added default Accept format header

* Simplified regex to match single relative date

* Fixed date check by forcing format

* Modified _api_key to be non required

* Made _api_key optional to support 10 free queries/day

* Added /rrsets API

* Moved files into separate dns0/ folder

* Created module structure and base file

* Extracted a common Mixin and applied to subclasses

* Resolved performance issue flagged by deepsource

* Added absolute import path

* Substituted dateutils with dateparser and updated requirements

* Updated Usage.md

* Added explanation in Advanced-Usage.md

* Fix dump

Signed-off-by: 0ssigeno <[email protected]>

* Black

Signed-off-by: 0ssigeno <[email protected]>

* Added analyzer config migrations

* Added new analyzers to FREE_TO_USE_ANALYZERS playbook

* Removed dns query type check

* Removed unused variable 'query'

* Added explicit default value in 'limit' parameter

* Added DNS0 api docs reference

* Solved deepsource warnings

* Added custom user agent

* Removed DNS0_rrsets_data

* Solved deepsource warning

* Added example JSON data

* Generalization of ids

Signed-off-by: 0ssigeno <[email protected]>

* Fix dumpplugin migration generation

Signed-off-by: 0ssigeno <[email protected]>

* Excluding id

Signed-off-by: 0ssigeno <[email protected]>

* Excluding id in migration

Signed-off-by: 0ssigeno <[email protected]>

* Added default parameter in test

* Added link to the DNS0 doc in plugin description

* Fix pipeline test #1

* Fix pipeline test n2

* Fix pipeline test n3

* Fix pipeline test n4

* Fix pipeline test n5

* Fix pipeline test n6

* Fix pipeline test n7

* Fix pipeline test n8

* Fix pipeline test n9

* Fix pipeline test n10

* Fix pipeline test n11

* Fix pipeline test n12

* Fix pipeline test n13

* Fix pipeline test n14

* Fix pipeline test n15

* Fix pipeline test n16

* Fix pipeline test n17

* Removed unused q parameter

---------

Signed-off-by: 0ssigeno <[email protected]>
Co-authored-by: 0ssigeno <[email protected]>

* Bump actions/setup-python from 4.7.0 to 5.0.0 (#2022)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.0 to 5.0.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4.7.0...v5.0.0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google-cloud-webrisk from 1.12.0 to 1.13.0 in /requirements (#2018)

Bumps [google-cloud-webrisk](https://github.com/googleapis/google-cloud-python) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/googleapis/google-cloud-python/releases)
- [Changelog](https://github.com/googleapis/google-cloud-python/blob/main/packages/google-cloud-documentai/CHANGELOG.md)
- [Commits](googleapis/google-cloud-python@google-cloud-webrisk-v1.12.0...google-cloud-webrisk-v1.13.0)

---
updated-dependencies:
- dependency-name: google-cloud-webrisk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Corner case migration

Signed-off-by: 0ssigeno <[email protected]>

* More logs

Signed-off-by: 0ssigeno <[email protected]>

* Fix

Signed-off-by: 0ssigeno <[email protected]>

* incremented logs in most used apis

* Elastic bi (#2036)

* Elastic bi

Signed-off-by: 0ssigeno <[email protected]>

* Elastic bi + fix elastic package

Signed-off-by: 0ssigeno <[email protected]>

* Update api_app/queryset.py

Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>

* Fix

Signed-off-by: 0ssigeno <[email protected]>

* Index template

Signed-off-by: 0ssigeno <[email protected]>

* Fixes

Signed-off-by: 0ssigeno <[email protected]>

---------

Signed-off-by: 0ssigeno <[email protected]>
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>

* changelog + docs + bump + django doctor + deepsource

* Bump github/codeql-action from 2 to 3 (#2033)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Commits](github/codeql-action@v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump authlib from 1.2.0 to 1.3.0 in /requirements (#2031)

Bumps [authlib](https://github.com/lepture/authlib) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/lepture/authlib/releases)
- [Changelog](https://github.com/lepture/authlib/blob/master/docs/changelog.rst)
- [Commits](authlib/authlib@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: authlib
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fixed permissions and log files for ClamAV

* Added IP and subdomain support for DNS0_rrsets_data  (#2042)

* Added IP support for DNS0_rrsets_data analyzer

* Added include_subdomain parameter

* Typo

* Restore original state

* Added alter migration to add a new supported type and new parameter

* fix deepsource

---------

Signed-off-by: 0ssigeno <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Daniele Rosetti <[email protected]>
Co-authored-by: 0ssigeno <[email protected]>
Co-authored-by: Martina Carella <[email protected]>
Co-authored-by: Daniele Rosetti <[email protected]>
Co-authored-by: fgibertoni <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Simone Berni <[email protected]>
Co-authored-by: code-review-doctor[bot] <72320148+code-review-doctor[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@drosetti